third_party/WebKit/Source/core/dom/IntersectionObservation.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

index 9222e00bfd13e2c773ae8b8f5c9e5084bd8ffc2a..ef5740b300218a885e18138e3023845329acb1d9 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

@@ -152,7 +152,7 @@ bool IntersectionObservation::computeGeometry(IntersectionGeometry& geometry) co

// the IntersectionObservation alive). During that interval, we need to check that m_target

// hasn't been cleared.

Element* targetElement = target();

- if (!targetElement || !targetElement->inDocument())

+ if (!targetElement || !targetElement->inShadowIncludingDocument())

return false;

LayoutObject* targetLayoutObject = targetElement->layoutObject();

ASSERT(m_observer);