tools/check-static-initializers.sh - Issue 1858143003: Get rid of UnsafeCurrent in Sampler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/check-static-initializers.sh

Issue 1858143003: Get rid of UnsafeCurrent in Sampler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address fadi's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/check-static-initializers.sh

diff --git a/tools/check-static-initializers.sh b/tools/check-static-initializers.sh

index da43170f6e670723df8bc1f5756709a0a46256c4..00e8f650d5e616a97a2bab174ad6bb1d58454243 100755

--- a/tools/check-static-initializers.sh

+++ b/tools/check-static-initializers.sh

@@ -32,7 +32,7 @@

# Allow:

# - _GLOBAL__I__ZN2v810LineEditor6first_E

# - _GLOBAL__I__ZN2v88internal32AtomicOps_Internalx86CPUFeaturesE

-expected_static_init_count=2

+expected_static_init_count=3

alph 2016/04/06 22:21:26 Is it true on Windows?

lpy 2016/04/06 23:51:38 Are we using check-static-initializers.sh on Windo

v8_root=$(readlink -f $(dirname $BASH_SOURCE)/../)

« src/profiler/sampler.cc ('K') | « src/profiler/sampler.cc ('k') | no next file » | no next file with comments »