content/renderer/geolocation_dispatcher.cc - Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/geolocation_dispatcher.cc

Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch android Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/geolocation_dispatcher.cc

diff --git a/content/renderer/geolocation_dispatcher.cc b/content/renderer/geolocation_dispatcher.cc

index a764b6107e2aa8fed1d33f4c8d5b016f62b6ccdf..7b48ca5da9b2e62196948385e7aa0f8ca55d4807 100644

--- a/content/renderer/geolocation_dispatcher.cc

+++ b/content/renderer/geolocation_dispatcher.cc

@@ -12,6 +12,7 @@

#include "third_party/WebKit/public/web/WebGeolocationClient.h"

#include "third_party/WebKit/public/web/WebGeolocationPosition.h"

#include "third_party/WebKit/public/web/WebGeolocationError.h"

+#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"

using blink::WebGeolocationController;

using blink::WebGeolocationError;

@@ -89,7 +90,8 @@ void GeolocationDispatcher::requestPermission(

int bridge_id = pending_permissions_->add(permissionRequest);

base::string16 origin = permissionRequest.securityOrigin().toString();

Send(new GeolocationHostMsg_RequestPermission(

- routing_id(), bridge_id, GURL(origin)));

+ routing_id(), bridge_id, GURL(origin),

+ blink::WebUserGestureIndicator::isProcessingUserGesture()));

}

// TODO(jknotten): Change the messages to use a security origin, so no

« no previous file with comments | « content/public/browser/geolocation_permission_context.h ('k') | no next file » | no next file with comments »