content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc - Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc

Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch android Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_geolocation_permission_context.h ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc

diff --git a/content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc b/content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc

index 8a803c4712058bfa89e25f400d99fc12c15ad6d8..6029fa05d61f00cb81d345b671a3a642aaffcb78 100644

--- a/content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc

+++ b/content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc

@@ -26,6 +26,7 @@ void BrowserPluginGeolocationPermissionContext::RequestGeolocationPermission(

int render_view_id,

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

base::Callback<void(bool)> callback) {

if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {

BrowserThread::PostTask(

@@ -38,6 +39,7 @@ void BrowserPluginGeolocationPermissionContext::RequestGeolocationPermission(

render_view_id,

bridge_id,

requesting_frame,

+ user_gesture,

callback));

return;

}

@@ -56,6 +58,7 @@ void BrowserPluginGeolocationPermissionContext::RequestGeolocationPermission(

BrowserPluginGuest* guest = guest_web_contents->GetBrowserPluginGuest();

guest->AskEmbedderForGeolocationPermission(bridge_id,

requesting_frame,

+ user_gesture,

callback);

}