android_webview/native/aw_geolocation_permission_context.cc - Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_geolocation_permission_context.cc

Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Patch android Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_geolocation_permission_context.h ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_geolocation_permission_context.cc

diff --git a/android_webview/native/aw_geolocation_permission_context.cc b/android_webview/native/aw_geolocation_permission_context.cc

index 3c2481ce36817cc330d73ee90def5a9cea96a077..b68608a5d0b91b1c43ae646fc58a08a7f3323dbd 100644

--- a/android_webview/native/aw_geolocation_permission_context.cc

+++ b/android_webview/native/aw_geolocation_permission_context.cc

@@ -22,6 +22,7 @@ AwGeolocationPermissionContext::RequestGeolocationPermissionOnUIThread(

int render_view_id,

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

base::Callback<void(bool)> callback) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

@@ -40,6 +41,7 @@ AwGeolocationPermissionContext::RequestGeolocationPermission(

int render_view_id,

int bridge_id,

const GURL& requesting_frame,

+ bool user_gesture,

base::Callback<void(bool)> callback) {

content::BrowserThread::PostTask(

content::BrowserThread::UI, FROM_HERE,

@@ -51,6 +53,7 @@ AwGeolocationPermissionContext::RequestGeolocationPermission(

render_view_id,

bridge_id,

requesting_frame,

+ user_gesture,

callback));

}