content/browser/geolocation/geolocation_dispatcher_host.cc - Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/geolocation_dispatcher_host.cc

Issue 185813004: [Geolocation] Attach user gesture indicator to permission request call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: plumb through Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/common/geolocation_messages.h » ('j') | content/renderer/geolocation_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/geolocation_dispatcher_host.cc

diff --git a/content/browser/geolocation/geolocation_dispatcher_host.cc b/content/browser/geolocation/geolocation_dispatcher_host.cc

index edb2692f36f232894ace3e678a8a17d9ec4c43d8..ceb71d97d49e11dac1d2bd3f89a692998a339c93 100644

--- a/content/browser/geolocation/geolocation_dispatcher_host.cc

+++ b/content/browser/geolocation/geolocation_dispatcher_host.cc

@@ -60,7 +60,8 @@ class GeolocationDispatcherHostImpl : public GeolocationDispatcherHost {

void OnRequestPermission(int render_view_id,

int bridge_id,

- const GURL& requesting_frame);

+ const GURL& requesting_frame,

+ bool user_gesture);

void OnCancelPermissionRequest(int render_view_id,

int bridge_id,

const GURL& requesting_frame);

@@ -159,7 +160,8 @@ void GeolocationDispatcherHostImpl::OnLocationUpdate(

void GeolocationDispatcherHostImpl::OnRequestPermission(

int render_view_id,

int bridge_id,

- const GURL& requesting_frame) {

+ const GURL& requesting_frame,

+ bool user_gesture) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

DVLOG(1) << __FUNCTION__ << " " << render_process_id_ << ":"

<< render_view_id << ":" << bridge_id;

@@ -169,6 +171,7 @@ void GeolocationDispatcherHostImpl::OnRequestPermission(

render_view_id,

bridge_id,

requesting_frame,

+ user_gesture,

base::Bind(&SendGeolocationPermissionResponse,

render_process_id_,

render_view_id,