Add "url-safe" encoding to base64 in dart:convert.

Add "url-safe" encoding to base64 in dart:convert.

Fixes issue #24813.
Doesn't add a second codec. The codec is unimportant,
only the BASE64 and BASE64URL constants need to be public anyway.

BUG= http://dartbug.com/24813
R=floitsch@google.com, nweiz@google.com

Committed: https://github.com/dart-lang/sdk/commit/3f0ad9d4f27c0fde6da86f3f0c003ab5bb5184a6

[Lasse Reichstein Nielsen, 2016-04-05 11:06:22]

lrn@google.com changed reviewers:
+ floitsch@google.com, nweiz@google.com

[Lasse Reichstein Nielsen, 2016-04-05 11:07:44]

https://codereview.chromium.org/1858113003/diff/1/sdk/lib/convert/base64.dart
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/1858113003/diff/1/sdk/lib/convert/base64.dart...
sdk/lib/convert/base64.dart:35: const Base64Codec BASE64URL = const
Base64Codec.urlSafe();
We could (and maybe should) change the type to Codec<List<int>,String>. The
Base64Codec class doesn't extend on that type at all, so there is no need for a
named Base64Codec type.

[floitsch, 2016-04-05 13:45:33]

LGTM.

https://codereview.chromium.org/1858113003/diff/1/sdk/lib/convert/base64.dart
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/1858113003/diff/1/sdk/lib/convert/base64.dart...
sdk/lib/convert/base64.dart:35: const Base64Codec BASE64URL = const
Base64Codec.urlSafe();
On 2016/04/05 11:07:44, Lasse Reichstein Nielsen wrote:
> We could (and maybe should) change the type to Codec<List<int>,String>. The
> Base64Codec class doesn't extend on that type at all, so there is no need for
a
> named Base64Codec type.

With the ChunkedConverter change it is better, if the type is not just "Codec",
since that one doesn't support chunked conversions.

[nweiz, 2016-04-05 21:36:33]

lgtm

[Lasse Reichstein Nielsen, 2016-04-07 14:36:31]

Description was changed from

==========
Add "url-safe" encoding to base64 in dart:convert.

Fixes issue #24813.
Doesn't add a second codec. The codec is unimportant,
only the BASE64 and BASE64URL constants need to be public anyway.

BUG= http://dartbug.com/24813
==========

to

==========
Add "url-safe" encoding to base64 in dart:convert.

Fixes issue #24813.
Doesn't add a second codec. The codec is unimportant,
only the BASE64 and BASE64URL constants need to be public anyway.

BUG= http://dartbug.com/24813
R=floitsch@google.com, nweiz@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3f0ad9d4f27c0fde6da86f3f0c003ab5bb5184a6
==========

[Lasse Reichstein Nielsen, 2016-04-07 14:36:34]

Committed patchset #3 (id:40001) manually as
3f0ad9d4f27c0fde6da86f3f0c003ab5bb5184a6 (presubmit successful).