third_party/WebKit/LayoutTests/bluetooth/notifications/start-stop-start-stop.html - Issue 1858103004: bluetooth: Separate notification tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/notifications/start-stop-start-stop.html

Issue 1858103004: bluetooth: Separate notification tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-notifications

Patch Set: Merge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-stop.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/notifications/start-fails.html ('k') | third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

11 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

13 .then(service => service.getCharacteristic('heart_rate_measurement'))	13 .then(service => service.getCharacteristic('heart_rate_measurement'))

14 .then(characteristic => {	14 .then(characteristic => {

15 return setBluetoothFakeAdapter('EmptyAdapter')	15 return characteristic.startNotifications()

16 .then(() => assert_promise_rejects_with_message(	16 .then(() => characteristic.stopNotifications())

17 characteristic.startNotifications(),	17 .then(() => characteristic.startNotifications())

18 new DOMException(	18 .then(() => characteristic.stopNotifications());
	Jeffrey Yasskin 2016/04/15 19:56:46 Was there a good reason to run garbage collection Was there a good reason to run garbage collection before? Were we checking for a crash or something? Or does GC automatically run at the end of tests, and splitting this to its own file gets it automatically? No comment needed; I'm just curious if the gc should come back. ortuno 2016/04/15 20:59:06 After a test finishes the document is detached whi Show quoted text On 2016/04/15 at 19:56:46, Jeffrey Yasskin wrote: > Was there a good reason to run garbage collection before? Were we checking for a crash or something? Or does GC automatically run at the end of tests, and splitting this to its own file gets it automatically? > > No comment needed; I'm just curious if the gc should come back. After a test finishes the document is detached which unsubscribes all the characteristics.
19 'Bluetooth Device is no longer in range.', 'NetworkError'),

20 'Device went out of range.'));

21 });	19 });

22 }, 'Device goes out of range. Reject with NetworkError.');	20 // Assert that notifications are not active.

	21 // http://crbug.com/600762

	22 }, 'Start -> stop -> start -> stop.');

23 </script>	23 </script>

OLD	NEW