third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html - Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console Base URL: https://chromium.googlesource.com/chromium/src.git@fix_472253_1

Patch Set: Rebase, attempt to fix 1 regressed expectation, temporary logging for investigating 2 other regress… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/appcache/video-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html b/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

index 2fe975473577e630e711e79848d6ac0d7b5f6045..d7743fdb955cda59c04771abb9404a0e45a69700 100644

--- a/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

+++ b/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html

@@ -17,6 +17,7 @@

mediasource_test(function(test, mediaElement, mediaSource)

{

+ // TODO(wolenetz): This endOfStream() shouldn't trigger a MediaError. See https://crbug.com/600810.

mediaSource.endOfStream();

assert_throws("InvalidStateError",

function() { mediaSource.addSourceBuffer(MediaSourceUtil.AUDIO_VIDEO_TYPE); },

@@ -39,7 +40,7 @@

"addSourceBuffer() threw an exception when passed null.");

test.done();

}, "Test addSourceBuffer() with null");

mediasource_test(function(test, mediaElement, mediaSource)

{

assert_throws("NotSupportedError",

@@ -90,7 +91,7 @@

assert_equals(mediaSource.activeSourceBuffers.length, 0, "SourceBuffer is not in mediaSource.activeSourceBuffers");

test.done();

}, "Test addSourceBuffer() video only");

mediasource_test(function(test, mediaElement, mediaSource)

{

var mimetype = MediaSourceUtil.AUDIO_ONLY_TYPE;