Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1858073002: Media: Report HTMLMediaElement player errors to devtools console Base URL: https://chromium.googlesource.com/chromium/src.git@fix_472253_1
Patch Set: Rebase, attempt to fix 1 regressed expectation, temporary logging for investigating 2 other regress… Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/video/video-controls-layer-creation-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index b0affc0dcbd287fe4ec1acd2aa91dbb40ec4a948..e91575e1c551971efa1aabe7ab741563e08a54ab 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -638,6 +638,12 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::getReadyState() const {
blink::WebString WebMediaPlayerImpl::getErrorMessage() {
DCHECK(main_task_runner_->BelongsToCurrentThread());
+
+ // ------------- TODO REMOVE before landing
+ // This is just to get a better idea of what the layout bots are seeing that's
+ // different from a local build, causing flakiness/failure on the bots.
+ LOG(ERROR) << "getErrorMessage: " << media_log_->GetLastErrorMessage();
+
return blink::WebString::fromUTF8(media_log_->GetLastErrorMessage());
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/video/video-controls-layer-creation-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698