Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1858063002: Remove Mac NPAPI things (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai, dcheng
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, nasko+codewatch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, stuartmorgan, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Mac NPAPI things A few Mac-specific messages were only used for NPAPI on Mac. We removed the renderer side, so these messages do nothing now and/or are never sent. Pull the thread on the browser side and remove corresponding things. BUG=493212 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/8a60f62c10333ec842dab85e2bc833a21996e0bc Cr-Commit-Position: refs/heads/master@{#385098}

Patch Set 1 #

Total comments: 3

Patch Set 2 : build fix #

Patch Set 3 : more build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -588 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 5 chunks +0 lines, -60 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 7 chunks +0 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 11 chunks +2 lines, -130 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +0 lines, -23 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/test/test_render_view_host.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/mozilla/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/mozilla/ComplexTextInputPanel.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/mozilla/ComplexTextInputPanel.mm View 1 chunk +0 lines, -147 lines 0 comments Download
M third_party/mozilla/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/mozilla/mozilla.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
piman
mark: please review dcheng: view_messages.h Please review carefully with extra suspicion, I have no idea ...
4 years, 8 months ago (2016-04-04 23:04:50 UTC) #3
Mark Mentovai
LGTM. Great! https://codereview.chromium.org/1858063002/diff/1/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm File chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm (left): https://codereview.chromium.org/1858063002/diff/1/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm#oldcode422 chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm:422: - (void)windowDidResize:(NSNotification*)notification { piman wrote: > \noideadog, ...
4 years, 8 months ago (2016-04-04 23:10:50 UTC) #4
dcheng
rslgtm for ipc deletions
4 years, 8 months ago (2016-04-04 23:13:10 UTC) #5
dcheng
rs lgtm even
4 years, 8 months ago (2016-04-04 23:13:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858063002/1
4 years, 8 months ago (2016-04-04 23:15:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/89943)
4 years, 8 months ago (2016-04-04 23:58:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858063002/20001
4 years, 8 months ago (2016-04-05 00:43:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/90065)
4 years, 8 months ago (2016-04-05 01:30:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858063002/40001
4 years, 8 months ago (2016-04-05 02:30:45 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 03:39:07 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 03:41:01 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a60f62c10333ec842dab85e2bc833a21996e0bc
Cr-Commit-Position: refs/heads/master@{#385098}

Powered by Google App Engine
This is Rietveld 408576698