Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: blimp/common/logging_unittest.cc

Issue 1858043003: [Blimp Net] logs input message type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/common/logging.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/logging_unittest.cc
diff --git a/blimp/common/logging_unittest.cc b/blimp/common/logging_unittest.cc
index 238aa59391dd2e4bb20cf4ca03a3fc3dd4138946..5c54511a74f752e48cd326257498683081dd3f8e 100644
--- a/blimp/common/logging_unittest.cc
+++ b/blimp/common/logging_unittest.cc
@@ -54,7 +54,13 @@ TEST_F(LoggingTest, Input) {
BlimpMessage base_msg;
base_msg.set_type(BlimpMessage::INPUT);
base_msg.set_target_tab_id(kTargetTab);
- VerifyLogOutput("type=INPUT render_widget_id=0 target_tab_id=123", base_msg);
+ base_msg.mutable_input()->set_type(InputMessage::Type_GestureScrollBegin);
+ base_msg.mutable_input()->set_render_widget_id(1);
+ base_msg.mutable_input()->set_timestamp_seconds(2);
+ VerifyLogOutput(
+ "type=INPUT render_widget_id=1 timestamp_seconds=2.000000 "
+ "subtype=GestureScrollBegin target_tab_id=123",
+ base_msg);
Kevin M 2016/04/05 16:57:39 Add additional tests to get coverage over all subt
haibinlu 2016/04/05 17:53:22 Done.
}
TEST_F(LoggingTest, Navigation) {
« no previous file with comments | « blimp/common/logging.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698