[Blimp Net] logs input message type.

[Blimp Net] logs input message type.

BUG=600444
Committed: https://crrev.com/0dd6f8d05ca9d3181e57fbfa3a9497402f60c842
Cr-Commit-Position: refs/heads/master@{#385258}

[haibinlu, 2016-04-05 00:32:23]

haibinlu@chromium.org changed reviewers:
+ kmarshall@chromium.org

[Kevin M, 2016-04-05 16:57:39]

https://codereview.chromium.org/1858043003/diff/1/blimp/common/logging_unitte...
File blimp/common/logging_unittest.cc (right):

https://codereview.chromium.org/1858043003/diff/1/blimp/common/logging_unitte...
blimp/common/logging_unittest.cc:63: base_msg);
Add additional tests to get coverage over all subtypes.

[haibinlu, 2016-04-05 17:53:22]

PTAL

https://codereview.chromium.org/1858043003/diff/1/blimp/common/logging_unitte...
File blimp/common/logging_unittest.cc (right):

https://codereview.chromium.org/1858043003/diff/1/blimp/common/logging_unitte...
blimp/common/logging_unittest.cc:63: base_msg);
On 2016/04/05 16:57:39, Kevin M wrote:
> Add additional tests to get coverage over all subtypes.

Done.

[Kevin M, 2016-04-05 17:59:13]

https://codereview.chromium.org/1858043003/diff/20001/blimp/common/logging_un...
File blimp/common/logging_unittest.cc (right):

https://codereview.chromium.org/1858043003/diff/20001/blimp/common/logging_un...
blimp/common/logging_unittest.cc:34: std::string
GetExpectedFragmentOfInputMessage(const std::string& type) {
We don't need to create a helper function like this. We can do this trivially
with a call to StringPrintf().

[haibinlu1, 2016-04-05 18:19:56]

haibinlu@google.com changed reviewers:
+ haibinlu@google.com

[haibinlu1, 2016-04-05 18:19:57]

PTAL

https://codereview.chromium.org/1858043003/diff/20001/blimp/common/logging_un...
File blimp/common/logging_unittest.cc (right):

https://codereview.chromium.org/1858043003/diff/20001/blimp/common/logging_un...
blimp/common/logging_unittest.cc:34: std::string
GetExpectedFragmentOfInputMessage(const std::string& type) {
On 2016/04/05 17:59:13, Kevin M wrote:
> We don't need to create a helper function like this. We can do this trivially
> with a call to StringPrintf().

Done.

[haibinlu, 2016-04-05 18:20:43]

Description was changed from

==========
[Blimp Net] logs input message type.


BUG=600444
==========

to

==========
[Blimp Net] logs input message type.


BUG=600444
==========

[haibinlu, 2016-04-05 18:20:43]

haibinlu@chromium.org changed reviewers:
- haibinlu@google.com

[Kevin M, 2016-04-05 18:32:06]

lgtm

[haibinlu, 2016-04-05 18:54:17]

The CQ bit was checked by haibinlu@chromium.org

[commit-bot: I haz the power, 2016-04-05 18:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858043003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858043003/40001

[commit-bot: I haz the power, 2016-04-05 19:41:42]

Description was changed from

==========
[Blimp Net] logs input message type.


BUG=600444
==========

to

==========
[Blimp Net] logs input message type.


BUG=600444
==========

[commit-bot: I haz the power, 2016-04-05 19:41:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 19:43:13]

Description was changed from

==========
[Blimp Net] logs input message type.


BUG=600444
==========

to

==========
[Blimp Net] logs input message type.

BUG=600444

Committed: https://crrev.com/0dd6f8d05ca9d3181e57fbfa3a9497402f60c842
Cr-Commit-Position: refs/heads/master@{#385258}
==========

[commit-bot: I haz the power, 2016-04-05 19:43:14]

Patchset 3 (id:??) landed as
https://crrev.com/0dd6f8d05ca9d3181e57fbfa3a9497402f60c842
Cr-Commit-Position: refs/heads/master@{#385258}