[ChromeOS] Do not send the memory pressure notification from chrome to renderers

Do not send the memory pressure notification from chrome to renderers

This is causing thrashing so let's disable until it is fixed.

BUG=588172
Committed: https://crrev.com/96b048f72b929b4edc99609cf953f274cb0ffdaf
Cr-Commit-Position: refs/heads/master@{#385096}

[oshima, 2016-04-04 22:36:02]

Description was changed from

==========
Do not send the memory pressure notification from chrome to renderer

BUG=588172
==========

to

==========
Do not send the memory pressure notification from chrome to renderers

This is causing thrashing so let's disable until it is fixed.

BUG=588172
==========

[oshima, 2016-04-04 22:36:02]

oshima@chromium.org changed reviewers:
+ chrisha@chromium.org, georgesak@chromium.org, sky@chromium.org

[oshima, 2016-04-04 22:37:24]

Patchset #1 (id:1) has been deleted

[oshima, 2016-04-04 22:37:57]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 22:38:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/20001

[oshima, 2016-04-04 22:40:30]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-04-04 22:40:35]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 22:40:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/40001

[oshima, 2016-04-04 22:41:25]

oshima@chromium.org changed reviewers:
- sky@chromium.org

[oshima, 2016-04-04 22:42:06]

Hi, we need to merge this to m50 beta. Can one of you review this today?

[commit-bot: I haz the power, 2016-04-04 22:59:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 22:59:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-04-04 23:01:30]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 23:02:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/60001

[oshima, 2016-04-04 23:34:52]

oshima@chromium.org changed reviewers:
+ sky@chromium.org

[oshima, 2016-04-04 23:34:53]

sky@, can you review this? I contacted georgesak@, but he was not at the office
now and he was ok to ask chrome/OWNERS.

[sky, 2016-04-04 23:46:35]

https://codereview.chromium.org/1858033002/diff/60001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/1858033002/diff/60001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:437: #if !defined(OS_CHROMEOS)
Can you conditionally run the test? By that I mean rename test to
MAYBE_ChildProcessNotifications and for chromeos map it to
DISABLED_ChildProcessNotifications?

[oshima, 2016-04-04 23:49:25]

https://codereview.chromium.org/1858033002/diff/60001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/1858033002/diff/60001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:437: #if !defined(OS_CHROMEOS)
On 2016/04/04 23:46:35, sky wrote:
> Can you conditionally run the test? By that I mean rename test to
> MAYBE_ChildProcessNotifications and for chromeos map it to
> DISABLED_ChildProcessNotifications?

Done.

[oshima, 2016-04-04 23:49:45]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 23:50:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/80001

[sky, 2016-04-04 23:51:38]

LGTM

https://codereview.chromium.org/1858033002/diff/80001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/1858033002/diff/80001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:454: // ChildProcessNotification
is disabled on ChromOS. crbug.com/588172.
nit: ChromeOS

[oshima, 2016-04-05 00:01:34]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-04-05 00:01:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1858033002/#ps100001
(title: " ")

[oshima, 2016-04-05 00:01:50]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2016-04-05 00:03:50]

https://codereview.chromium.org/1858033002/diff/80001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_unittest.cc (right):

https://codereview.chromium.org/1858033002/diff/80001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_unittest.cc:454: // ChildProcessNotification
is disabled on ChromOS. crbug.com/588172.
On 2016/04/04 23:51:37, sky wrote:
> nit: ChromeOS

Done.

[oshima, 2016-04-05 00:05:43]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:06:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/100001

[commit-bot: I haz the power, 2016-04-05 00:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:17:29]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[oshima, 2016-04-05 00:22:44]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:23:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/100001

[commit-bot: I haz the power, 2016-04-05 00:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:24:43]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[oshima, 2016-04-05 00:57:15]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:57:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/100001

[commit-bot: I haz the power, 2016-04-05 01:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 01:41:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-04-05 01:49:37]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-04-05 01:49:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1858033002/#ps120001
(title: "gied ifdef")

[commit-bot: I haz the power, 2016-04-05 01:50:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858033002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858033002/120001

[commit-bot: I haz the power, 2016-04-05 03:07:24]

Description was changed from

==========
Do not send the memory pressure notification from chrome to renderers

This is causing thrashing so let's disable until it is fixed.

BUG=588172
==========

to

==========
Do not send the memory pressure notification from chrome to renderers

This is causing thrashing so let's disable until it is fixed.

BUG=588172
==========

[commit-bot: I haz the power, 2016-04-05 03:07:25]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-04-05 03:09:03]

Description was changed from

==========
Do not send the memory pressure notification from chrome to renderers

This is causing thrashing so let's disable until it is fixed.

BUG=588172
==========

to

==========
Do not send the memory pressure notification from chrome to renderers

This is causing thrashing so let's disable until it is fixed.

BUG=588172

Committed: https://crrev.com/96b048f72b929b4edc99609cf953f274cb0ffdaf
Cr-Commit-Position: refs/heads/master@{#385096}
==========

[commit-bot: I haz the power, 2016-04-05 03:09:05]

Patchset 5 (id:??) landed as
https://crrev.com/96b048f72b929b4edc99609cf953f274cb0ffdaf
Cr-Commit-Position: refs/heads/master@{#385096}

[chrisha, 2016-04-05 13:36:58]

Is this a little draconic? Rather than disabling the entire notification
mechanism, can't we simply eliminate the GCs on reception of the notification?
There are other things (empty caches, page buffers, etc) that could still be
useful and likely aren't janky. (Testing would be required.)