Source/modules/indexeddb/IDBRequest.cpp - Issue 18580013: IndexedDB: Make DOMException messages more useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBRequest.cpp

Issue 18580013: IndexedDB: Make DOMException messages more useful. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Specific message for inactive transactions Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/indexeddb/IDBRequest.cpp

diff --git a/Source/modules/indexeddb/IDBRequest.cpp b/Source/modules/indexeddb/IDBRequest.cpp

index b13b961ce7f4bb0b691d0b2dd8a9492b7792bb08..0e40e4525d0ec38e1598de4a8b9912beff747783 100644

--- a/Source/modules/indexeddb/IDBRequest.cpp

+++ b/Source/modules/indexeddb/IDBRequest.cpp

@@ -95,7 +95,7 @@ IDBRequest::~IDBRequest()

PassRefPtr<IDBAny> IDBRequest::result(ExceptionState& es) const

{

if (m_readyState != DONE) {

- es.throwDOMException(InvalidStateError);

+ es.throwDOMException(InvalidStateError, IDBDatabase::requestNotFinishedErrorMessage);

return 0;

}

return m_result;

@@ -104,7 +104,7 @@ PassRefPtr<IDBAny> IDBRequest::result(ExceptionState& es) const

PassRefPtr<DOMError> IDBRequest::error(ExceptionState& es) const

{

if (m_readyState != DONE) {

- es.throwDOMException(InvalidStateError);

+ es.throwDOMException(InvalidStateError, IDBDatabase::requestNotFinishedErrorMessage);

return 0;

}

return m_error;