Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: Source/modules/indexeddb/IDBFactory.cpp

Issue 18580013: IndexedDB: Make DOMException messages more useful. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Specific message for inactive transactions Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/indexeddb/IDBDatabase.cpp ('k') | Source/modules/indexeddb/IDBIndex.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 short IDBFactory::cmp(ScriptExecutionContext* context, const ScriptValue& firstV alue, const ScriptValue& secondValue, ExceptionState& es) 151 short IDBFactory::cmp(ScriptExecutionContext* context, const ScriptValue& firstV alue, const ScriptValue& secondValue, ExceptionState& es)
152 { 152 {
153 DOMRequestState requestState(context); 153 DOMRequestState requestState(context);
154 RefPtr<IDBKey> first = scriptValueToIDBKey(&requestState, firstValue); 154 RefPtr<IDBKey> first = scriptValueToIDBKey(&requestState, firstValue);
155 RefPtr<IDBKey> second = scriptValueToIDBKey(&requestState, secondValue); 155 RefPtr<IDBKey> second = scriptValueToIDBKey(&requestState, secondValue);
156 156
157 ASSERT(first); 157 ASSERT(first);
158 ASSERT(second); 158 ASSERT(second);
159 159
160 if (!first->isValid() || !second->isValid()) { 160 if (!first->isValid() || !second->isValid()) {
161 es.throwDOMException(DataError); 161 es.throwDOMException(DataError, IDBDatabase::notValidKeyErrorMessage);
162 return 0; 162 return 0;
163 } 163 }
164 164
165 return static_cast<short>(first->compare(second.get())); 165 return static_cast<short>(first->compare(second.get()));
166 } 166 }
167 167
168 } // namespace WebCore 168 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/indexeddb/IDBDatabase.cpp ('k') | Source/modules/indexeddb/IDBIndex.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698