media/filters/video_renderer_base.cc - Issue 18580008: Rename VideoDecoder::HasOutputFrameAvailable() to CanReadWithoutStalling().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_base.cc

Issue 18580008: Rename VideoDecoder::HasOutputFrameAvailable() to CanReadWithoutStalling(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: name change and drop disabled (invalid) test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/video_renderer_base.cc

diff --git a/media/filters/video_renderer_base.cc b/media/filters/video_renderer_base.cc

index a39c8b09848ea07fe6fc04071e8bfb9cd261e948..5c6c16821c41456949559b33135ab0572283455d 100644

--- a/media/filters/video_renderer_base.cc

+++ b/media/filters/video_renderer_base.cc

@@ -396,7 +396,7 @@ void VideoRendererBase::FrameReady(VideoDecoder::Status status,

AddReadyFrame_Locked(frame);

if (state_ == kPrerolling) {

- if (!video_frame_stream_.HasOutputFrameAvailable() ||

+ if (!video_frame_stream_.CanReadWithoutStalling() ||

ready_frames_.size() >= static_cast<size_t>(limits::kMaxVideoFrames)) {

TransitionToPrerolled_Locked();

}

« no previous file with comments | « media/filters/video_frame_stream.cc ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »