media/filters/gpu_video_decoder.cc - Issue 18580008: Rename VideoDecoder::HasOutputFrameAvailable() to CanReadWithoutStalling().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 18580008: Rename VideoDecoder::HasOutputFrameAvailable() to CanReadWithoutStalling(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: name change and drop disabled (invalid) test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index 3679a5acc00070115b260953644e79979462014c..8cf51ad101a76c7a78aaec78ca20b916dd43b8a5 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -480,9 +480,9 @@ bool GpuVideoDecoder::NeedsBitstreamConversion() const {

return needs_bitstream_conversion_;

}

-bool GpuVideoDecoder::HasOutputFrameAvailable() const {

+bool GpuVideoDecoder::CanReadWithoutStalling() const {

DCHECK(gvd_loop_proxy_->BelongsToCurrentThread());

- return available_pictures_ > 0;

+ return available_pictures_ > 0 || !ready_video_frames_.empty();

}

void GpuVideoDecoder::NotifyInitializeDone() {

« no previous file with comments | « media/filters/gpu_video_decoder.h ('k') | media/filters/video_frame_stream.h » ('j') | no next file with comments »