[Quota] Pass user gesture state with quota request message.

webkit/common/quota/quota_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_COMMON_QUOTA_QUOTA_TYPES_H_
 #define WEBKIT_COMMON_QUOTA_QUOTA_TYPES_H_
 
+#include "url/gurl.h"
 #include "webkit/common/quota/quota_status_code.h"
+#include "webkit/common/webkit_storage_common_export.h"
 
 namespace quota {
 
 enum StorageType {
   kStorageTypeTemporary,
   kStorageTypePersistent,
   kStorageTypeSyncable,
   kStorageTypeQuotaNotManaged,
   kStorageTypeUnknown,
 };
 
 enum QuotaLimitType {
   kQuotaLimitTypeUnknown,
   kQuotaLimitTypeLimited,
   kQuotaLimitTypeUnlimited,
 };
 
+struct WEBKIT_STORAGE_COMMON_EXPORT RequestStorageQuotaParams {

[kinuko, 2014/03/04 01:55:40]

It feels having this in content/common/quota is more appropriate (putting aside
that this file itself is going to be merged into there), since this is only for
messaging/UI

[Greg Billock, 2014/03/04 18:49:37]

So in the messages file itself? I can do that.

[kinuko, 2014/03/05 01:07:35]

I meant another file in content/common, but the current location is ok with me
too-- can you add a brief comment to this struct? Then this lg to me

[Greg Billock, 2014/03/05 18:20:31]

Done. I'll leave it here, then, esp. if these are moving to content/common
anyway -- then it'll move along with the enums.

+  RequestStorageQuotaParams();
+  ~RequestStorageQuotaParams();
+
+  int render_view_id;

[kinuko, 2014/03/04 01:49:09]

Strictly speaking referring render_view_id in webkit/ feels a bit wrong, but
given that webkit/ is being merged into content/ this should be fine...

[Greg Billock, 2014/03/04 18:49:37]

ok.

+  int request_id;
+  GURL origin_url;
+  quota::StorageType storage_type;

[kinuko, 2014/03/04 01:49:09]

nit: no need of quota:: here

[Greg Billock, 2014/03/04 18:49:37]

Done.

+  uint64 requested_size;
+  bool user_gesture;

[kinuko, 2014/03/04 01:55:40]

It's not obvious what does this flag means here-- can we have some comment?
Is boolean enough / best for this flag, or enum might be better?

[Greg Billock, 2014/03/04 18:49:37]

Basically that the message originated in the context of a user gesture. A
boolean is enough.

+};
+
 }  // namespace quota
 
 #endif  // WEBKIT_COMMON_QUOTA_QUOTA_TYPES_H_