Chromium Code Reviews

Issue 185793002: A64: Handle a few TODOs. (Closed)

Created:
6 years, 9 months ago by Alexandre Rames
Modified:
6 years, 9 months ago
Reviewers:
ulan, jochen (gone - plz use gerrit)
CC:
v8-dev
Visibility:
Public.

Description

A64: Handle a few TODOs. Notes about a few TODOs handled in this patch: * In ProfileEntryHookStub::Generate: Stubs are always called with relocation. * In CreateArrayDispatchOneArgument: The branches to registers can't be conditional. We could use a jump table, but there are only 6 different kinds so it is likely not worth it. * In Builtins::Generate_StringConstructCode: Rename the argc register (x0) after its meaning changes. Remove a TODO: using a macro would not make the code clearer. * In Generate_JSEntryTrampolineHelper: Remove the TODO and raise an internal issue to investigate this. * In Disassembler::SubstituteBranchTargetField: Print the target address, but we don't have more info on the target. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19724

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+52 lines, -66 lines)
M src/a64/builtins-a64.cc View 4 chunks +7 lines, -9 lines 0 comments
M src/a64/code-stubs-a64.cc View 4 chunks +8 lines, -15 lines 0 comments
M src/a64/disasm-a64.cc View 2 chunks +4 lines, -4 lines 0 comments
M src/a64/lithium-codegen-a64.cc View 1 chunk +1 line, -6 lines 0 comments
M test/cctest/test-disasm-a64.cc View 2 chunks +32 lines, -32 lines 0 comments

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 9 months ago (2014-03-03 14:30:35 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-04 09:46:00 UTC) #2
Alexandre Rames
6 years, 9 months ago (2014-03-07 15:20:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19724 (presubmit successful).

Powered by Google App Engine