Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1857923002: Fix ParseConfigs_OutParam tests (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M tests/TestConfigParsing.cpp View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857923002/1
4 years, 8 months ago (2016-04-04 19:01:53 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-04 19:01:55 UTC) #4
hal.canary
ptal
4 years, 8 months ago (2016-04-04 19:02:01 UTC) #6
egdaniel
lgtm
4 years, 8 months ago (2016-04-04 19:02:58 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 19:14:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3c4521a196d7ead2a984826070be377d524c2c51

Powered by Google App Engine
This is Rietveld 408576698