Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1857843002: mac: Fix copying from the Omnibox. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, James Su, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix copying from the Omnibox. This CL makes several small changes. 1. The Omnibox now clears the pasteboard before copying into it. 2. Clipboard utility classes now use the UTI compliant NSPasteboardTypeString variable, which replaces NSStringPboardType. 3. A new browser test was written to prevent this regression from happening again. BUG=600207 Committed: https://crrev.com/49a52026c1fadd6c83b7eaae68512142ff076864 Cr-Commit-Position: refs/heads/master@{#384981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_browsertest.mm View 2 chunks +37 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_mac.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/base/clipboard/clipboard_util_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
erikchen
avi: Please review.
4 years, 8 months ago (2016-04-04 17:40:45 UTC) #2
Avi (use Gerrit)
On 2016/04/04 17:40:45, erikchen wrote: > avi: Please review. BUG?
4 years, 8 months ago (2016-04-04 18:24:40 UTC) #3
Avi (use Gerrit)
LGTM with bug link.
4 years, 8 months ago (2016-04-04 18:26:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857843002/1
4 years, 8 months ago (2016-04-04 18:37:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 19:41:02 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 19:42:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49a52026c1fadd6c83b7eaae68512142ff076864
Cr-Commit-Position: refs/heads/master@{#384981}

Powered by Google App Engine
This is Rietveld 408576698