[SystemInfo API] Move Storage API out of experimental namespace and rename to the "system" namespace

chrome/common/extensions/api/system_storage.idl

Index: chrome/common/extensions/api/system_storage.idl
diff --git a/chrome/common/extensions/api/experimental_system_info_storage.idl b/chrome/common/extensions/api/system_storage.idl
similarity index 76%
copy from chrome/common/extensions/api/experimental_system_info_storage.idl
copy to chrome/common/extensions/api/system_storage.idl
index 9ae9aff78b687dd65d19344cd66e23df3bc8a49f..0f14b54426fed56cf33c3e7479899c028bf84e64 100644
--- a/chrome/common/extensions/api/experimental_system_info_storage.idl
+++ b/chrome/common/extensions/api/system_storage.idl
@@ -2,9 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Use the <code>chrome.experimental.systemInfo.storage</code> API to query
-// storage device information and be notified when it changes.
-namespace experimental.systemInfo.storage {
+// Use the <code>chrome.system.storage</code> API to query storage device
+// information and be notified when a removable storage device is attached and
+// detached or the available capacity changes.
+namespace system.storage {
 
   enum StorageUnitType {
     // The storage has fixed media, e.g. hard disk or SSD.
@@ -23,10 +24,23 @@ namespace experimental.systemInfo.storage {
     // The media type of the storage unit.
     StorageUnitType type;
     // The total amount of the storage space, in bytes.
-    // Default value is 0 if query operation fails.
     double capacity;
   };
 
+  dictionary StorageFreeSpaceChangeInfo {
+    // The transient id of the storage unit already changed.
+    DOMString id;
+    // The new value of the available capacity.
+    double availableCapacity;
+  };
+
+  // A dictionary that describes the add particular storage device watch
+  // request results.
+  dictionary AddAvailableCapacityWatchResult {
+    DOMString id;
+    boolean success;
+  };
+
   [inline_doc] enum EjectDeviceResultCode {
     // The ejection command is successful -- the application can prompt the user
     // to remove the device.
@@ -41,32 +55,20 @@ namespace experimental.systemInfo.storage {
     failure
   };
 
-  dictionary StorageFreeSpaceChangeInfo {
-    // The transient id of the storage unit already changed.
-    DOMString id;
-    // The new value of the available capacity.
-    double availableCapacity;
-  };
-
-  // A dictionary that describes the add particular storage device watch
-  // request results.
-  dictionary AddWatchResult {
-    DOMString id;
-    boolean success;
-  };
+  callback AddAvailableCapacityWatchCallback = void (
+      AddAvailableCapacityWatchResult info);
 
-  callback StorageInfoCallback = void (StorageUnitInfo[] info);
+  callback GetAllAvailableCapacityWatchesCallback = void (
+      DOMString[] storageIds);
 
   callback EjectDeviceCallback = void (EjectDeviceResultCode result);
 
-  callback AddWatchCallback = void (AddWatchResult info);
-
-  callback GetAllWatchCallback = void (DOMString[] storageIds);
+  callback StorageInfoCallback = void (StorageUnitInfo[] info);
 
   interface Functions {
     // Get the storage information from the system. The argument passed to the
     // callback is an array of StorageUnitInfo objects.
-    static void get(StorageInfoCallback callback);
+    static void getInfo(StorageInfoCallback callback);
 
     // Ejects a removable storage device.
     // Note: We plan to move this function into a namespace that indicates it
@@ -75,28 +77,31 @@ namespace experimental.systemInfo.storage {
     static void ejectDevice(DOMString id, EjectDeviceCallback callback);
 
     // Monitor a particular storage device available change capacity.
-    static void addWatch(DOMString id, AddWatchCallback callback);
+    static void addAvailableCapacityWatch(

[not at google - send to devlin, 2013/07/24 16:01:47]

... but we're about to delete this API method, right?

[Haojian Wu, 2013/07/25 04:21:57]

But I don't know we plan to delete this API. Any details about it?

[not at google - send to devlin, 2013/07/25 14:35:51]

I see. I am remembering this CL:
https://chromiumcodereview.appspot.com/19672022/ which removed the
availableCapacity field from the StorageUnitInfo struct.

I should have asked this at the time of that CL, but are we also going to delete
the onAvailableCapacityChanged event? It seems like an event that is very easy
to introduce bad behaviour with (extension gets available capacity; logs it;
available capacity changes; etc).

[Haojian Wu, 2013/07/25 15:36:56]

In original API review meeting, we decide to keep the
onAvaialableCapacityChanged event in experimental namespace. And in the rename
"systemInfo" namespace discussion, we restrict this event in dev-channel.

+        DOMString id,
+        AddAvailableCapacityWatchCallback callback);
 
     // Remove the monitor of a particular device.
-    static void removeWatch(DOMString id);
+    static void removeAvailableCapacityWatch(DOMString id);
 
     // Get all the watched storage devices.
-    static void getAllWatch(GetAllWatchCallback callback);
+    static void getAllAvailableCapacityWatches(
+        GetAllAvailableCapacityWatchesCallback callback);
 
     // Remove all the storage devices monitors.
-    static void removeAllWatch();
+    static void removeAllAvailableCapacityWatches();
   };
 
   interface Events {
-    // Fired when the storage device available capacity is changed.
-    // |info|: The changed information for the specified storage unit.
-    static void onAvailableCapacityChanged(StorageFreeSpaceChangeInfo info);
-
     // Fired when a new removable storage is attached to the system.
     static void onAttached(StorageUnitInfo info);
 
     // Fired when a removable storage is detached from the system.
     static void onDetached(DOMString id);
+
+    // Fired when the storage device available capacity is changed.
+    // |info|: The changed information for the specified storage unit.
+    static void onAvailableCapacityChanged(StorageFreeSpaceChangeInfo info);
   };
 
 };