Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3012)

Unified Diff: chrome/browser/extensions/api/system_info/system_info_api.cc

Issue 18578008: [SystemInfo API] Move Storage API out of experimental namespace and rename to the "system" namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info/system_info_api.cc
diff --git a/chrome/browser/extensions/api/system_info/system_info_api.cc b/chrome/browser/extensions/api/system_info/system_info_api.cc
index d2039485c345d60a6be018aa7485c5f268dc69de..92ece0dd449387a7a6aae5bef449dd7998f1e0ab 100644
--- a/chrome/browser/extensions/api/system_info/system_info_api.cc
+++ b/chrome/browser/extensions/api/system_info/system_info_api.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/storage_monitor/storage_info.h"
#include "chrome/browser/storage_monitor/storage_monitor.h"
#include "chrome/common/extensions/api/experimental_system_info_storage.h"
+#include "chrome/common/extensions/api/system_info_storage.h"
#include "ui/gfx/display_observer.h"
#if defined(USE_ASH)
@@ -31,8 +32,8 @@
namespace extensions {
using api::experimental_system_info_storage::StorageFreeSpaceChangeInfo;
-using api::experimental_system_info_storage::StorageUnitInfo;
-using api::experimental_system_info_storage::StorageUnitType;
+using api::system_info_storage::StorageUnitInfo;
+using api::system_info_storage::StorageUnitType;
using content::BrowserThread;
namespace {
@@ -85,8 +86,7 @@ class SystemInfoEventRouter : public gfx::DisplayObserver,
virtual void OnRemovableStorageDetached(
const chrome::StorageInfo& info) OVERRIDE;
- void DispatchStorageAttachedEvent(const chrome::StorageInfo& info,
- int64 avail_bytes);
+ void DispatchStorageAttachedEvent(const chrome::StorageInfo& info);
// Called from any thread to dispatch the systemInfo event to all extension
// processes cross multiple profiles.
@@ -217,29 +217,14 @@ void SystemInfoEventRouter::OnFreeSpaceChanged(
void SystemInfoEventRouter::OnRemovableStorageAttached(
const chrome::StorageInfo& info) {
- base::PostTaskAndReplyWithResult(
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN),
- FROM_HERE,
- base::Bind(&StorageInfoProvider::GetStorageFreeSpaceFromTransientId,
- StorageInfoProvider::Get(),
- StorageInfoProvider::Get()->GetTransientIdForDeviceId(
- info.device_id())),
- base::Bind(&SystemInfoEventRouter::DispatchStorageAttachedEvent,
- // Since SystemInfoEventRouter is a global lazy instance, this
- // pointer will be alive when the reply comes back.
- base::Unretained(this),
- info));
+ DispatchStorageAttachedEvent(info);
}
void SystemInfoEventRouter::DispatchStorageAttachedEvent(
- const chrome::StorageInfo& info, int64 avail_bytes) {
+ const chrome::StorageInfo& info) {
StorageUnitInfo unit;
systeminfo::BuildStorageUnitInfo(info, &unit);
- unit.available_capacity =
- avail_bytes > 0 ? static_cast<double>(avail_bytes) : 0;
-
scoped_ptr<base::ListValue> args(new base::ListValue);
args->Append(unit.ToValue().release());
DispatchEvent(event_names::kOnStorageAttached, args.Pass());

Powered by Google App Engine
This is Rietveld 408576698