Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1857753002: MIPS: Fix Run_Wasm_F32CopySign (Closed)

Created:
4 years, 8 months ago by ivica.bogosavljevic
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix Run_Wasm_F32CopySign. Run_Wasm_F32CopySign was failing because function copysign that is used to verify the results does implicit conversion from float to double. In this conversion we lose information about NaN sign and the test fails. Fix by using copysignf to avoid unnecessary float to double conversion. TEST=cctest/test-run-wasm/Run_Wasm_F32CopySign BUG= Committed: https://crrev.com/114c109a326facae2bb5edfdfd030dd7041b7767 Cr-Commit-Position: refs/heads/master@{#35237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
ivica.bogosavljevic
4 years, 8 months ago (2016-04-04 12:18:18 UTC) #3
titzer
lgtm
4 years, 8 months ago (2016-04-04 12:18:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857753002/1
4 years, 8 months ago (2016-04-04 12:26:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 12:48:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857753002/1
4 years, 8 months ago (2016-04-04 12:57:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 12:59:31 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 12:59:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/114c109a326facae2bb5edfdfd030dd7041b7767
Cr-Commit-Position: refs/heads/master@{#35237}

Powered by Google App Engine
This is Rietveld 408576698