third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp - Issue 1857713004: DevTools: simplify the async instrumentation harness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

Issue 1857713004: DevTools: simplify the async instrumentation harness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: same with scriptpromiseresolver Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fileapi/FileReader.cpp ('K') | « third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h ('k') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('j') | third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

index b2f77ac3603b9fa72ec6e6c99aad554b430fb2b5..ecf8642498f774fb82a4eb1a97b8bbaa1fd08cb6 100644

--- a/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp

@@ -35,7 +35,6 @@

#include "core/dom/Document.h"

#include "core/frame/FrameConsole.h"

#include "core/frame/LocalFrame.h"

-#include "core/inspector/AsyncCallTracker.h"

#include "core/inspector/InspectedFrames.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/InspectorTraceEvents.h"

@@ -116,12 +115,4 @@ void PageDebuggerAgent::didStartProvisionalLoad(LocalFrame* frame)

}

-void PageDebuggerAgent::didClearDocumentOfWindowObject(LocalFrame* frame)

- // FIXME: what about nested objects?

- if (frame != m_inspectedFrames->root())

- return;

- m_asyncCallTracker->resetAsyncOperations();

} // namespace blink