third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp - Issue 1857713004: DevTools: simplify the async instrumentation harness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

Issue 1857713004: DevTools: simplify the async instrumentation harness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: same with scriptpromiseresolver Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fileapi/FileReader.cpp ('K') | « third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('j') | third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

index e7238f90ecf41b3b538d0700749f994f00783dfb..27e815636bbfc1969b464f3eb8940c69a866a27e 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

@@ -31,15 +31,15 @@ int DOMTimerCoordinator::installNewTimeout(ExecutionContext* context, ScheduledA

return timeoutID;

}

-void DOMTimerCoordinator::removeTimeoutByID(int timeoutID)

+DOMTimer* DOMTimerCoordinator::removeTimeoutByID(int timeoutID)

{

if (timeoutID <= 0)

- return;

+ return nullptr;

if (DOMTimer* removedTimer = m_timers.get(timeoutID))

removedTimer->disposeTimer();

- m_timers.remove(timeoutID);

+ return m_timers.take(timeoutID);

}

DEFINE_TRACE(DOMTimerCoordinator)