Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857713004: DevTools: simplify the async instrumentation harness. (Closed)

Created:
4 years, 8 months ago by pfeldman
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, shans, tzik, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, jsbell+idb_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, sof, nhiroki, loading-reviews_chromium.org, lushnikov+blink_chromium.org, darktears, haraken, Nate Chapin, tyoshino+watch_chromium.org, blink-reviews-animation_chromium.org, pfeldman+blink_chromium.org, cmumford, sergeyv+blink_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: simplify the async instrumentation harness. Committed: https://crrev.com/9fb5380b49bdcb6e859ac32906539ae77d6c66c0 Cr-Commit-Position: refs/heads/master@{#385542}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : tests pass #

Patch Set 4 : same with scriptpromiseresolver #

Total comments: 17

Patch Set 5 : all comments addressed #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : indexeddb patched #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -1301 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/filesystem/async-callstack-filesystem.html View 1 2 3 4 5 1 chunk +0 lines, -111 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/filesystem/async-callstack-filesystem-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -94 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-fetch.html View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-fetch-expected.txt View 1 2 3 1 chunk +18 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-middle-run.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-mutation-observer-expected.txt View 1 2 3 4 5 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 2 3 4 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MainThreadTaskRunner.cpp View 1 2 3 4 3 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 1 2 3 4 5 6 7 5 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/GenericEventQueue.cpp View 1 2 3 4 5 6 4 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 2 3 4 5 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/AsyncCallTracker.h View 1 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/AsyncCallTracker.cpp View 1 2 1 chunk +0 lines, -428 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 3 4 8 chunks +30 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 4 5 6 7 8 9 7 chunks +25 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 2 3 4 5 6 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 3 4 5 6 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp View 4 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.cpp View 1 2 3 4 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp View 1 2 3 4 5 6 7 2 chunks +14 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp View 1 2 3 4 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransaction.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp View 1 2 3 4 5 6 7 8 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h View 1 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.cpp View 1 1 chunk +0 lines, -117 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 2 3 4 5 6 7 8 4 chunks +13 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 4 5 6 7 8 9 chunks +77 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h View 1 2 3 4 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 35 (15 generated)
pfeldman
4 years, 8 months ago (2016-04-05 00:55:45 UTC) #2
dgozman
https://codereview.chromium.org/1857713004/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1857713004/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp#newcode165 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:165: void V8DebuggerAgent::asyncTaskStarted(void* task) Remove.
4 years, 8 months ago (2016-04-05 01:09:49 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/60001
4 years, 8 months ago (2016-04-06 01:32:18 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/45883)
4 years, 8 months ago (2016-04-06 01:47:04 UTC) #7
dgozman
https://codereview.chromium.org/1857713004/diff/60001/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-web-sql-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-web-sql-expected.txt (right): https://codereview.chromium.org/1857713004/diff/60001/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-web-sql-expected.txt#newcode29 third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-web-sql-expected.txt:29: 0) onSuccess (async-callstack-web-sql.html:14) What happened to this one? https://codereview.chromium.org/1857713004/diff/60001/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp ...
4 years, 8 months ago (2016-04-06 02:31:09 UTC) #8
pfeldman
All done. https://codereview.chromium.org/1857713004/diff/60001/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp File third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp (right): https://codereview.chromium.org/1857713004/diff/60001/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp#newcode26 third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp:26: InspectorInstrumentation::scheduleAsyncTask(m_context, "requestAnimationFrame", callback); On 2016/04/06 02:31:08, dgozman ...
4 years, 8 months ago (2016-04-06 04:51:36 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/80001
4 years, 8 months ago (2016-04-06 04:52:05 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/193078)
4 years, 8 months ago (2016-04-06 05:41:06 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/100001
4 years, 8 months ago (2016-04-06 15:28:18 UTC) #15
dgozman
Why did all the tests change? https://codereview.chromium.org/1857713004/diff/100001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1857713004/diff/100001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp#newcode1087 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1087: // - asyncTaskCanceled ...
4 years, 8 months ago (2016-04-06 16:04:12 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/27344)
4 years, 8 months ago (2016-04-06 16:17:54 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/120001
4 years, 8 months ago (2016-04-06 17:22:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/140001
4 years, 8 months ago (2016-04-06 18:04:17 UTC) #22
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-06 18:04:21 UTC) #24
pfeldman
https://codereview.chromium.org/1857713004/diff/100001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1857713004/diff/100001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp#newcode1087 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1087: // - asyncTaskCanceled <-- canceled before finished On 2016/04/06 ...
4 years, 8 months ago (2016-04-06 18:25:20 UTC) #25
dgozman
lgtm
4 years, 8 months ago (2016-04-06 18:28:33 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/160001
4 years, 8 months ago (2016-04-06 18:49:43 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857713004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857713004/180001
4 years, 8 months ago (2016-04-06 19:07:52 UTC) #32
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 8 months ago (2016-04-06 20:21:47 UTC) #33
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:24:02 UTC) #35
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/9fb5380b49bdcb6e859ac32906539ae77d6c66c0
Cr-Commit-Position: refs/heads/master@{#385542}

Powered by Google App Engine
This is Rietveld 408576698