core/fxcrt/include/fx_string.h - Issue 1857713003: Rename GetCStr and GetPtr to match CFX_ByteString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1857713003: Rename GetCStr and GetPtr to match CFX_ByteString (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/include/fx_string.h

diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h

index 9aa67845f877425b52f0981734980d411a1a6511..2e35ff7f8058b4430226e778d829e364419cb548 100644

--- a/core/fxcrt/include/fx_string.h

+++ b/core/fxcrt/include/fx_string.h

@@ -93,7 +93,7 @@ class CFX_ByteStringC {

uint32_t GetID(FX_STRSIZE start_pos = 0) const;

const uint8_t* GetPtr() const { return m_Ptr; }

- const FX_CHAR* GetCStr() const { return (const FX_CHAR*)m_Ptr; }

+ const FX_CHAR* c_str() const { return (const FX_CHAR*)m_Ptr; }

Tom Sepez 2016/04/04 18:22:40 nit: reinterpret cast.

dsinclair 2016/04/04 18:33:34 Done.

FX_STRSIZE GetLength() const { return m_Length; }

bool IsEmpty() const { return m_Length == 0; }

« no previous file with comments | « core/fxcrt/fxcrt_windows.cpp ('k') | core/fxge/android/fpf_skiafontmgr.cpp » ('j') | no next file with comments »