Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857703002: Move comment above associated declaration so some GUIs can pick it up. (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move comment above associated declaration so some GUIs can pick it up. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/f5b8511b05f18c56d62a685022963baccfb79eba Cr-Commit-Position: refs/heads/master@{#35228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast/ast.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 8 months ago (2016-04-04 08:25:53 UTC) #1
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-04 08:27:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857703002/1
4 years, 8 months ago (2016-04-04 08:28:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 08:51:37 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 08:52:19 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5b8511b05f18c56d62a685022963baccfb79eba
Cr-Commit-Position: refs/heads/master@{#35228}

Powered by Google App Engine
This is Rietveld 408576698