Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1857693002:
Remove now-unused kConstantInModule. (Closed)
DescriptionRemove now-unused kConstantInModule.
TBR=thakis,wfh
BUG=550065
Committed: https://crrev.com/cc375c7319222b6ba528aae1559f3046daa1a379
Cr-Commit-Position: refs/heads/master@{#384866}
Patch Set 1 #
Messages
Total messages: 17 (5 generated)
Description was changed from ========== Remove now-unused kConstantInModule. TBR=thakis,wfh BUG=550065 ========== to ========== Remove now-unused kConstantInModule. TBR=thakis,wfh BUG=550065 ==========
sigbjornf@opera.com changed reviewers: + thakis@chromium.org
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857693002/1
Message was sent while issue was closed.
Description was changed from ========== Remove now-unused kConstantInModule. TBR=thakis,wfh BUG=550065 ========== to ========== Remove now-unused kConstantInModule. TBR=thakis,wfh BUG=550065 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove now-unused kConstantInModule. TBR=thakis,wfh BUG=550065 ========== to ========== Remove now-unused kConstantInModule. TBR=thakis,wfh BUG=550065 Committed: https://crrev.com/cc375c7319222b6ba528aae1559f3046daa1a379 Cr-Commit-Position: refs/heads/master@{#384866} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cc375c7319222b6ba528aae1559f3046daa1a379 Cr-Commit-Position: refs/heads/master@{#384866}
Message was sent while issue was closed.
On 2016/04/04 08:33:54, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/cc375c7319222b6ba528aae1559f3046daa1a379 > Cr-Commit-Position: refs/heads/master@{#384866} Lgtm, thanks!
Message was sent while issue was closed.
Now that I have a keyboard: First, again, thank you very much for fixing this. Second, mostly out of interest, how did you notice that https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... was broken? As far as I understand, since that bot is (for now) still marked as experimental, nobody should receive failure emails from it or should have red boxes on their reviews unless they tick "show experimental bots" in their rietveld settings. Maybe you checked that (for oilpan)?
Message was sent while issue was closed.
On 2016/04/04 13:43:14, Nico wrote: > Now that I have a keyboard: First, again, thank you very much for fixing this. > Second, mostly out of interest, how did you notice that > https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... > was broken? As far as I understand, since that bot is (for now) still marked as > experimental, nobody should receive failure emails from it or should have red > boxes on their reviews unless they tick "show experimental bots" in their > rietveld settings. Maybe you checked that (for oilpan)? "git cl try" includes win_clang.
Message was sent while issue was closed.
On 2016/04/04 13:49:17, sof wrote: > On 2016/04/04 13:43:14, Nico wrote: > > Now that I have a keyboard: First, again, thank you very much for fixing this. > > Second, mostly out of interest, how did you notice that > > > https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... > > was broken? As far as I understand, since that bot is (for now) still marked > as > > experimental, nobody should receive failure emails from it or should have red > > boxes on their reviews unless they tick "show experimental bots" in their > > rietveld settings. Maybe you checked that (for oilpan)? > > "git cl try" includes win_clang. Yes (it runs on 100% of trybots), but from what I understand it shouldn't show up as a red box on rietveld and shouldn't send you mail as far as I understand. For example, I ran `git cl try` on https://codereview.chromium.org/1852143002/ (I run it on almost all my CLs, instead of using "dry run"), and it doesn't have a red box and I didn't receive a mail either.
Message was sent while issue was closed.
On 2016/04/04 13:55:28, Nico wrote: > On 2016/04/04 13:49:17, sof wrote: > > On 2016/04/04 13:43:14, Nico wrote: > > > Now that I have a keyboard: First, again, thank you very much for fixing > this. > > > Second, mostly out of interest, how did you notice that > > > > > > https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... > > > was broken? As far as I understand, since that bot is (for now) still marked > > as > > > experimental, nobody should receive failure emails from it or should have > red > > > boxes on their reviews unless they tick "show experimental bots" in their > > > rietveld settings. Maybe you checked that (for oilpan)? > > > > "git cl try" includes win_clang. > > Yes (it runs on 100% of trybots), but from what I understand it shouldn't show > up as a red box on rietveld and shouldn't send you mail as far as I understand. > For example, I ran `git cl try` on https://codereview.chromium.org/1852143002/ > (I run it on almost all my CLs, instead of using "dry run"), and it doesn't have > a red box and I didn't receive a mail either. I see; I wonder why it is quite prominent for me, e.g., https://codereview.chromium.org/1850413002/#ps100001 (using the deprecated ui, fwiw.)
Message was sent while issue was closed.
On 2016/04/04 14:01:05, sof wrote: > On 2016/04/04 13:55:28, Nico wrote: > > On 2016/04/04 13:49:17, sof wrote: > > > On 2016/04/04 13:43:14, Nico wrote: > > > > Now that I have a keyboard: First, again, thank you very much for fixing > > this. > > > > Second, mostly out of interest, how did you notice that > > > > > > > > > > https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... > > > > was broken? As far as I understand, since that bot is (for now) still > marked > > > as > > > > experimental, nobody should receive failure emails from it or should have > > red > > > > boxes on their reviews unless they tick "show experimental bots" in their > > > > rietveld settings. Maybe you checked that (for oilpan)? > > > > > > "git cl try" includes win_clang. > > > > Yes (it runs on 100% of trybots), but from what I understand it shouldn't show > > up as a red box on rietveld and shouldn't send you mail as far as I > understand. > > For example, I ran `git cl try` on https://codereview.chromium.org/1852143002/ > > (I run it on almost all my CLs, instead of using "dry run"), and it doesn't > have > > a red box and I didn't receive a mail either. > > I see; I wonder why it is quite prominent for me, e.g., > https://codereview.chromium.org/1850413002/#ps100001 Hm, I see the red box there too. Strange! On https://codereview.chromium.org/settings, what's "Display experimental trybot results" set to for you? > (using the deprecated ui, fwiw.) I think almost everyone is. I'm not sure why it's called "deprecated", not "default".
Message was sent while issue was closed.
On 2016/04/04 14:03:23, Nico wrote: > On 2016/04/04 14:01:05, sof wrote: > > On 2016/04/04 13:55:28, Nico wrote: > > > On 2016/04/04 13:49:17, sof wrote: > > > > On 2016/04/04 13:43:14, Nico wrote: > > > > > Now that I have a keyboard: First, again, thank you very much for fixing > > > this. > > > > > Second, mostly out of interest, how did you notice that > > > > > > > > > > > > > > > https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... > > > > > was broken? As far as I understand, since that bot is (for now) still > > marked > > > > as > > > > > experimental, nobody should receive failure emails from it or should > have > > > red > > > > > boxes on their reviews unless they tick "show experimental bots" in > their > > > > > rietveld settings. Maybe you checked that (for oilpan)? > > > > > > > > "git cl try" includes win_clang. > > > > > > Yes (it runs on 100% of trybots), but from what I understand it shouldn't > show > > > up as a red box on rietveld and shouldn't send you mail as far as I > > understand. > > > For example, I ran `git cl try` on > https://codereview.chromium.org/1852143002/ > > > (I run it on almost all my CLs, instead of using "dry run"), and it doesn't > > have > > > a red box and I didn't receive a mail either. > > > > I see; I wonder why it is quite prominent for me, e.g., > > https://codereview.chromium.org/1850413002/#ps100001 > > Hm, I see the red box there too. Strange! > > On https://codereview.chromium.org/settings, what's "Display experimental trybot > results" set to for you? > "Never"
Message was sent while issue was closed.
Hm, ok. Weird, thanks. Since it'll hopefully be non-experimental soon, I won't worry about this too much I guess. On Mon, Apr 4, 2016 at 7:06 AM, <sigbjornf@opera.com> wrote: > On 2016/04/04 14:03:23, Nico wrote: > > On 2016/04/04 14:01:05, sof wrote: > > > On 2016/04/04 13:55:28, Nico wrote: > > > > On 2016/04/04 13:49:17, sof wrote: > > > > > On 2016/04/04 13:43:14, Nico wrote: > > > > > > Now that I have a keyboard: First, again, thank you very much for > fixing > > > > this. > > > > > > Second, mostly out of interest, how did you notice that > > > > > > > > > > > > > > > > > > > > > > https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang?numbui... > > > > > > was broken? As far as I understand, since that bot is (for now) > still > > > marked > > > > > as > > > > > > experimental, nobody should receive failure emails from it or > should > > have > > > > red > > > > > > boxes on their reviews unless they tick "show experimental bots" > in > > their > > > > > > rietveld settings. Maybe you checked that (for oilpan)? > > > > > > > > > > "git cl try" includes win_clang. > > > > > > > > Yes (it runs on 100% of trybots), but from what I understand it > shouldn't > > show > > > > up as a red box on rietveld and shouldn't send you mail as far as I > > > understand. > > > > For example, I ran `git cl try` on > > https://codereview.chromium.org/1852143002/ > > > > (I run it on almost all my CLs, instead of using "dry run"), and it > doesn't > > > have > > > > a red box and I didn't receive a mail either. > > > > > > I see; I wonder why it is quite prominent for me, e.g., > > > https://codereview.chromium.org/1850413002/#ps100001 > > > > Hm, I see the red box there too. Strange! > > > > On https://codereview.chromium.org/settings, what's "Display > experimental > trybot > > results" set to for you? > > > > "Never" > > https://codereview.chromium.org/1857693002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
