chrome/browser/autofill: scoped_ptr -> unique_ptr

chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-QucCgAJ,
which I hope was not an April Fool's joke. :)

BUG=600221
Committed: https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967
Cr-Commit-Position: refs/heads/master@{#384900}

[vabr (Chromium), 2016-04-04 01:41:47]

Description was changed from

==========
chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-...,
which I hope was not an April Fool's joke. :)

BUG=554298
==========

to

==========
chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-...,
which I hope was not an April Fool's joke. :)

BUG=600221
==========

[vabr (Chromium), 2016-04-04 02:18:52]

vabr@chromium.org changed reviewers:
+ mathp@chromium.org

[vabr (Chromium), 2016-04-04 02:18:53]

Hi Mathieu,

And one more similar refactoring. Could you please have a look? This (as well as
https://codereview.chromium.org/1859453002/) is just scripted and spot-checked
applying of those steps:
(1) replace #include "base/memory/scoped_ptr.h" with <memory>
(2) replace make_scoped_ptr with base::WrapUnique and adding the #include for
the latter where needed
(3) renaming scoped_ptr to std::unique_ptr
(4) git cl format
These steps are also specified in the linked spreadsheet (2nd spreadsheet in
that file).

Cheers,
Vaclav

[Mathieu, 2016-04-04 13:15:46]

lgtm with nits, thanks!

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_interactive_uitest.cc (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_interactive_uitest.cc:5: #include <memory>
not sure if this is needed anymore?

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/con...
File chrome/browser/autofill/content_autofill_driver_browsertest.cc (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/con...
chrome/browser/autofill/content_autofill_driver_browsertest.cc:5: #include
<memory>
may not be needed, 

include base/memory/ref_counted.h for scoped_refptr

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/per...
File chrome/browser/autofill/personal_data_manager_factory.cc (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/per...
chrome/browser/autofill/personal_data_manager_factory.cc:7: #include <memory>
may not be needed?

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/ris...
File chrome/browser/autofill/risk_util.h (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/ris...
chrome/browser/autofill/risk_util.h:10: #include <memory>
include it in risk_util.cc instead

[vabr (Chromium), 2016-04-04 13:28:41]

Thank you!
Comments addressed, sending to the CQ.

Cheers,
Vaclav

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_interactive_uitest.cc (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_interactive_uitest.cc:5: #include <memory>
On 2016/04/04 13:15:46, Mathieu Perreault wrote:
> not sure if this is needed anymore?

Good catch!
Removed, because there is no unique_ptr in the file.

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/con...
File chrome/browser/autofill/content_autofill_driver_browsertest.cc (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/con...
chrome/browser/autofill/content_autofill_driver_browsertest.cc:5: #include
<memory>
On 2016/04/04 13:15:46, Mathieu Perreault wrote:
> may not be needed, 
> 
> include base/memory/ref_counted.h for scoped_refptr

Done.

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/per...
File chrome/browser/autofill/personal_data_manager_factory.cc (right):

https://codereview.chromium.org/1857663002/diff/1/chrome/browser/autofill/per...
chrome/browser/autofill/personal_data_manager_factory.cc:7: #include <memory>
On 2016/04/04 13:15:46, Mathieu Perreault wrote:
> may not be needed?

Done.

[vabr (Chromium), 2016-04-04 13:28:45]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-04-04 13:28:45]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1857663002/#ps20001
(title: "Comments addressed")

[commit-bot: I haz the power, 2016-04-04 13:28:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857663002/20001

[commit-bot: I haz the power, 2016-04-04 14:08:49]

Description was changed from

==========
chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-...,
which I hope was not an April Fool's joke. :)

BUG=600221
==========

to

==========
chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-...,
which I hope was not an April Fool's joke. :)

BUG=600221
==========

[commit-bot: I haz the power, 2016-04-04 14:08:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-04 14:10:16]

Description was changed from

==========
chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-...,
which I hope was not an April Fool's joke. :)

BUG=600221
==========

to

==========
chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-...,
which I hope was not an April Fool's joke. :)

BUG=600221

Committed: https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967
Cr-Commit-Position: refs/heads/master@{#384900}
==========

[commit-bot: I haz the power, 2016-04-04 14:10:17]

Patchset 2 (id:??) landed as
https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967
Cr-Commit-Position: refs/heads/master@{#384900}