Introduce ForwardGraphemeBoundaryStateMachine

Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain
the following grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.
Subsequent CL will use this class.

BUG=594923
Committed: https://crrev.com/7e8a5d82b32386818839d8f874395f37eb3184bf
Cr-Commit-Position: refs/heads/master@{#385678}

[Seigo Nonaka, 2016-04-03 19:27:11]

Description was changed from

==========
Introduce ForwardGraphemeBoundaryStateMachine

BUG=
==========

to

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain the following
grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.

BUG=594923
==========

[Seigo Nonaka, 2016-04-03 19:27:11]

nona@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2016-04-04 04:15:55]

https://codereview.chromium.org/1857633002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp
(right):

https://codereview.chromium.org/1857633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp:89:
if (m_nextCodePoint == 0) {
Let's introduce more state into |InternalState| and dispatch base on it rather
than checking |m_pendingCodeUnit|, |m_nextCodePoint| to make control-flow
simpler as state machine.

[Seigo Nonaka, 2016-04-05 10:55:32]

Description was changed from

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain the following
grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.

BUG=594923
==========

to

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain
the following grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.
Subsequent CL will use this class.

BUG=594923
==========

[Seigo Nonaka, 2016-04-05 11:01:00]

Patchset #2 (id:20001) has been deleted

[Seigo Nonaka, 2016-04-05 11:01:34]

Thank you for your review.
I applied same style as BackwardGraphemeBoundary.

Could you kindly take a look?

Thank you.

https://codereview.chromium.org/1857633002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp
(right):

https://codereview.chromium.org/1857633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp:89:
if (m_nextCodePoint == 0) {
On 2016/04/04 04:15:55, Yosi_UTC9 wrote:
> Let's introduce more state into |InternalState| and dispatch base on it rather
> than checking |m_pendingCodeUnit|, |m_nextCodePoint| to make control-flow
> simpler as state machine.

Done.

[yosin_UTC9, 2016-04-06 01:29:15]

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp
(right):

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp:92:
}
For consistency with other |NOTREACEHD()| in this switch-statement, better to
have |return finish();| here.

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp
(right):

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp:112:
DCHECK_EQ(machine->finalizeAndGetBoundaryOffset(),
Since |DCHECK()| terminates gTest, it is better to return distinguished value,
e.g. "not finished yet".

[Seigo Nonaka, 2016-04-06 04:17:26]

Thank you for your review.
Plesae take an another look.

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp
(right):

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp:92:
}
On 2016/04/06 01:29:15, Yosi_UTC9 wrote:
> For consistency with other |NOTREACEHD()| in this switch-statement, better to
> have |return finish();| here.

Done.

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp
(right):

https://codereview.chromium.org/1857633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp:112:
DCHECK_EQ(machine->finalizeAndGetBoundaryOffset(),
On 2016/04/06 01:29:15, Yosi_UTC9 wrote:
> Since |DCHECK()| terminates gTest, it is better to return distinguished value,
> e.g. "not finished yet".

Sure, Fixed.

[yosin_UTC9, 2016-04-06 07:18:34]

yosin@chromium.org changed reviewers:
+ keishi@chromium.org

[yosin_UTC9, 2016-04-06 07:18:35]

lgtm

+keishi@, for core.gypi changes

[Seigo Nonaka, 2016-04-06 09:06:07]

Yosi-san! thank you for your quick review! 

Keishi-san, could you kindly take a look?

Thank you.

[Seigo Nonaka, 2016-04-07 04:29:26]

friendly ping, keishi-san.

[keishi, 2016-04-07 04:37:35]

Sorry, LGTM

[Seigo Nonaka, 2016-04-07 04:43:49]

No worries! I'm sorry for hurrying up you.

Submitting...

[Seigo Nonaka, 2016-04-07 04:43:54]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2016-04-07 04:44:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857633002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857633002/120001

[commit-bot: I haz the power, 2016-04-07 04:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 04:46:40]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Seigo Nonaka, 2016-04-07 04:53:34]

The CQ bit was checked by nona@chromium.org

[Seigo Nonaka, 2016-04-07 04:53:35]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1857633002/#ps140001
(title: "rebasing")

[commit-bot: I haz the power, 2016-04-07 04:53:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857633002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857633002/140001

[commit-bot: I haz the power, 2016-04-07 06:25:43]

Description was changed from

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain
the following grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.
Subsequent CL will use this class.

BUG=594923
==========

to

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain
the following grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.
Subsequent CL will use this class.

BUG=594923
==========

[commit-bot: I haz the power, 2016-04-07 06:25:44]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-04-07 06:27:14]

Description was changed from

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain
the following grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.
Subsequent CL will use this class.

BUG=594923
==========

to

==========
Introduce ForwardGraphemeBoundaryStateMachine

ForwardGraphemeBoundaryStateMachine provides a way to obtain
the following grapheme boundary.

ForwardGraphemeBoundaryStateMachine is compiled and tested
but not yet used in production with this CL.
Subsequent CL will use this class.

BUG=594923

Committed: https://crrev.com/7e8a5d82b32386818839d8f874395f37eb3184bf
Cr-Commit-Position: refs/heads/master@{#385678}
==========

[commit-bot: I haz the power, 2016-04-07 06:27:15]

Patchset 7 (id:??) landed as
https://crrev.com/7e8a5d82b32386818839d8f874395f37eb3184bf
Cr-Commit-Position: refs/heads/master@{#385678}

[esprehn, 2016-04-12 18:40:54]

This patch is incorrectly using std::vector and std::string, please switch to
WTF::String and WTF::Vector. core does not use stl vectors or strings.

[yosin_UTC9, 2016-04-13 04:54:01]

On 2016/04/12 at 18:40:54, esprehn wrote:
> This patch is incorrectly using std::vector and std::string, please switch to
WTF::String and WTF::Vector. core does not use stl vectors or strings.

Oh sorry... m(_ _)m
I change std::vector and std::string to WTF::Vector and WTF::String.

[yosin_UTC9, 2016-04-13 04:54:20]

On 2016/04/13 at 04:54:01, Yosi_UTC9 wrote:
> On 2016/04/12 at 18:40:54, esprehn wrote:
> > This patch is incorrectly using std::vector and std::string, please switch
to WTF::String and WTF::Vector. core does not use stl vectors or strings.
> 
> Oh sorry... m(_ _)m
> I change std::vector and std::string to WTF::Vector and WTF::String.

http://crrev.com/1884893002