Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1857623002: Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. (Closed)

Created:
4 years, 8 months ago by Will Harris
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. BUG=600201 Committed: https://crrev.com/c15c402bb15f5587b760340e06b0751966dda9da Cr-Commit-Position: refs/heads/master@{#385073}

Patch Set 1 #

Patch Set 2 : mark test as flaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Will Harris
PTAL
4 years, 8 months ago (2016-04-03 18:14:05 UTC) #3
Peter Kasting
This isn't right. From what I read in the widget update uitest this could fail ...
4 years, 8 months ago (2016-04-04 07:41:18 UTC) #5
Will Harris
On 2016/04/04 07:41:18, Peter Kasting wrote: > This isn't right. From what I read in ...
4 years, 8 months ago (2016-04-04 23:53:48 UTC) #7
Peter Kasting
Let's go ahead and get this in so I don't hold anyone else up.
4 years, 8 months ago (2016-04-05 00:03:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857623002/20001
4 years, 8 months ago (2016-04-05 00:04:31 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-05 00:04:33 UTC) #12
Will Harris
eek bots are in a bad way because maybe of https://chromium.googlesource.com/chromium/src/+/1c9b02233631b0ba9b096d79bf5b8d71a370dbb0
4 years, 8 months ago (2016-04-05 00:12:12 UTC) #13
Will Harris
On 2016/04/05 00:12:12, Will Harris wrote: > eek bots are in a bad way because ...
4 years, 8 months ago (2016-04-05 00:20:41 UTC) #14
Peter Kasting
On 2016/04/05 00:20:41, Will Harris wrote: > On 2016/04/05 00:12:12, Will Harris wrote: > > ...
4 years, 8 months ago (2016-04-05 00:24:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857623002/20001
4 years, 8 months ago (2016-04-05 00:25:42 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 01:30:26 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 01:31:30 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c15c402bb15f5587b760340e06b0751966dda9da
Cr-Commit-Position: refs/heads/master@{#385073}

Powered by Google App Engine
This is Rietveld 408576698