|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by Will Harris Modified:
4 years, 8 months ago Reviewers:
Peter Kasting CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows.
BUG=600201
Committed: https://crrev.com/c15c402bb15f5587b760340e06b0751966dda9da
Cr-Commit-Position: refs/heads/master@{#385073}
Patch Set 1 #Patch Set 2 : mark test as flaky #Messages
Total messages: 21 (9 generated)
Description was changed from ========== BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor on Win10 BUG=600201 ========== to ========== BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor on Win10 BUG=600201 ==========
wfh@chromium.org changed reviewers: + pkasting@chromium.org
PTAL
Description was changed from ========== BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor on Win10 BUG=600201 ========== to ========== Disable BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor on Win10 BUG=600201 ==========
This isn't right. From what I read in the widget update uitest this could fail on any Windows version. I'll fix this correctly tomorrow, er, today (since it's past midnight). If something needs in urgently, just mark the test FLAKY.
Description was changed from ========== Disable BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor on Win10 BUG=600201 ========== to ========== Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. BUG=600201 ==========
On 2016/04/04 07:41:18, Peter Kasting wrote: > This isn't right. From what I read in the widget update uitest this could fail > on any Windows version. I'll fix this correctly tomorrow, er, today (since it's > past midnight). If something needs in urgently, just mark the test FLAKY. okay I just marked it as FLAKY instead. If you don't think you'll be able to land the proper fix before tomorrow then can you just CQ this so we can turn the Win10 bot green? Thanks!
Let's go ahead and get this in so I don't hold anyone else up.
The CQ bit was checked by pkasting@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
eek bots are in a bad way because maybe of https://chromium.googlesource.com/chromium/src/+/1c9b02233631b0ba9b096d79bf5b...
On 2016/04/05 00:12:12, Will Harris wrote: > eek bots are in a bad way because maybe of > https://chromium.googlesource.com/chromium/src/+/1c9b02233631b0ba9b096d79bf5b... okay that's fixed in https://chromium.googlesource.com/chromium/src/+/031aebddd2c595f9bcbf9c11457b... can I haz l-g-t-m?
On 2016/04/05 00:20:41, Will Harris wrote: > On 2016/04/05 00:12:12, Will Harris wrote: > > eek bots are in a bad way because maybe of > > > https://chromium.googlesource.com/chromium/src/+/1c9b02233631b0ba9b096d79bf5b... > > okay that's fixed in > https://chromium.googlesource.com/chromium/src/+/031aebddd2c595f9bcbf9c11457b... > > can I haz l-g-t-m? Oops. LGTM.
The CQ bit was checked by pkasting@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857623002/20001
Message was sent while issue was closed.
Description was changed from ========== Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. BUG=600201 ========== to ========== Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. BUG=600201 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. BUG=600201 ========== to ========== Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows. BUG=600201 Committed: https://crrev.com/c15c402bb15f5587b760340e06b0751966dda9da Cr-Commit-Position: refs/heads/master@{#385073} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c15c402bb15f5587b760340e06b0751966dda9da Cr-Commit-Position: refs/heads/master@{#385073} |
