Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/v8.py

Issue 1857613002: Upgrade v8.todomvc{,-ignition} to TBMv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 21469a2864ba379161f0b767f2ec2f6b7ea97fe0..873fdc6594b9144b5d35561c8db08ddfa356ca11 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -147,7 +147,7 @@ class V8TodoMVC(perf_benchmark.PerfBenchmark):
category_filter.AddIncludedCategory('v8')
category_filter.AddIncludedCategory('blink.console')
options = timeline_based_measurement.Options(category_filter)
- options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])
+ options.SetTimelineBasedMetric('executionMetric')
return options
@classmethod
@@ -172,7 +172,7 @@ class V8TodoMVCIgnition(perf_benchmark.PerfBenchmark):
category_filter.AddIncludedCategory('v8')
category_filter.AddIncludedCategory('blink.console')
options = timeline_based_measurement.Options(category_filter)
- options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])
+ options.SetTimelineBasedMetric('executionMetric')
return options
@classmethod
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698