Issue 18576005: [Mac] Adds a flag to force 10.6-style fullscreen for testing.

Issue 18576005: [Mac] Adds a flag to force 10.6-style fullscreen for testing. (Closed)

Created:
7 years, 5 months ago by rohitrao (ping after 24h)

Modified:
7 years, 5 months ago

Reviewers:
Robert Sesek, scheib, Nico

CC:
chromium-reviews, scheib+watch_chromium.org, jennb, jianli, Dmitry Titov, dcheng

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Mac] Adds a flag to force 10.6-style fullscreen for testing. Adds a new SupportsSystemFullscreen() method, which can be overridden by a command-line flag to enable 10.6-style fullscreen for testing on newer OSes. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211699

Patch Set 1 #

Patch Set 2 : Typos. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Patch Set 5 : Remove broken DCHECK. #

Total comments: 1

Patch Set 6 : Rebased. #

Patch Set 7 : Rebased. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -28 lines)			Patch
M	chrome/browser/fullscreen.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/fullscreen_mac.mm	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_commands_mac.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	1 2 3 4 5	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm	View	1 2 3 4 5	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1 2 3 4 5	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1 2 3 4 5	7 chunks	+15 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm	View	1 2 3 4 5	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/presentation_mode_controller.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/fullscreen/fullscreen_controller.cc	View	1 2 3 4 5	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc	View		5 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

+sky for chrome/browser/fullscreen* and chrome/browser/ui/browser_commands_mac.cc (the first three files in the list). +scheib for chrome/browser/ui/fullscreen

7 years, 5 months ago (2013-07-10 18:14:48 UTC) #3

scheib

lgtm https://codereview.chromium.org/18576005/diff/23001/chrome/browser/ui/fullscreen/fullscreen_controller.cc File chrome/browser/ui/fullscreen/fullscreen_controller.cc (right): https://codereview.chromium.org/18576005/diff/23001/chrome/browser/ui/fullscreen/fullscreen_controller.cc#newcode30 chrome/browser/ui/fullscreen/fullscreen_controller.cc:30: #include "base/mac/mac_util.h" You can remove this include now.

7 years, 5 months ago (2013-07-10 19:47:58 UTC) #4

rohitrao (ping after 24h)

Adding Nico for OWNERS review of: chrome/browser/fullscreen* chrome/browser/ui/browser_commands_mac.mm

7 years, 5 months ago (2013-07-12 15:59:54 UTC) #5

Nico

On 2013/07/12 15:59:54, rohitrao wrote: > Adding Nico for OWNERS review of: > chrome/browser/fullscreen* > ...

7 years, 5 months ago (2013-07-15 16:47:51 UTC) #6

rohitrao (ping after 24h)

Updated the CL description. Thanks for the review!

7 years, 5 months ago (2013-07-15 16:52:34 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/18576005/32001

7 years, 5 months ago (2013-07-15 16:53:27 UTC) #8

Message was sent while issue was closed.

Change committed as 211699

Expand Messages | Collapse Messages