Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Side by Side Diff: chrome/browser/net/predictor_tab_helper.h

Issue 1857573002: [reland] Change net's predictor_tab_helper to use the new content Navigation API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update finch test config on chromeos Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/net/predictor_browsertest.cc ('k') | chrome/browser/net/predictor_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_PREDICTOR_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_NET_PREDICTOR_TAB_HELPER_H_
6 #define CHROME_BROWSER_NET_PREDICTOR_TAB_HELPER_H_ 6 #define CHROME_BROWSER_NET_PREDICTOR_TAB_HELPER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/public/browser/notification_observer.h" 9 #include "content/public/browser/notification_observer.h"
10 #include "content/public/browser/notification_registrar.h" 10 #include "content/public/browser/notification_registrar.h"
11 #include "content/public/browser/web_contents_observer.h" 11 #include "content/public/browser/web_contents_observer.h"
12 #include "content/public/browser/web_contents_user_data.h" 12 #include "content/public/browser/web_contents_user_data.h"
13 13
14 namespace content {
15 class NavigationHandle;
16 }
17
14 namespace chrome_browser_net { 18 namespace chrome_browser_net {
15 19
16 class PredictorTabHelper 20 class PredictorTabHelper
17 : public content::WebContentsObserver, 21 : public content::WebContentsObserver,
18 public content::WebContentsUserData<PredictorTabHelper> { 22 public content::WebContentsUserData<PredictorTabHelper> {
19 public: 23 public:
20 ~PredictorTabHelper() override; 24 ~PredictorTabHelper() override;
21 25
22 // content::WebContentsObserver implementation 26 // content::WebContentsObserver:
27 void DidStartNavigation(
28 content::NavigationHandle* navigation_handle) override;
23 void DidStartNavigationToPendingEntry( 29 void DidStartNavigationToPendingEntry(
24 const GURL& url, 30 const GURL& url,
25 content::NavigationController::ReloadType reload_type) override; 31 content::NavigationController::ReloadType reload_type) override;
26 32
27 private: 33 private:
28 explicit PredictorTabHelper(content::WebContents* web_contents); 34 explicit PredictorTabHelper(content::WebContents* web_contents);
29 friend class content::WebContentsUserData<PredictorTabHelper>; 35 friend class content::WebContentsUserData<PredictorTabHelper>;
30 36
37 void PreconnectUrl(const GURL& url);
38
39 // This boolean is set to true after a call to
40 // DidStartNavigationToPendingEntry, which fires off predictive preconnects.
41 // This ensures that the resulting call to DidStartNavigation does not
42 // duplicate these preconnects. The tab helper spawns preconnects on the
43 // navigation to the pending entry because DidStartNavigation is called after
44 // render process spawn (pre-PlzNavigate), which can take substantial time
45 // especially on Android.
46 bool predicted_from_pending_entry_;
47
31 DISALLOW_COPY_AND_ASSIGN(PredictorTabHelper); 48 DISALLOW_COPY_AND_ASSIGN(PredictorTabHelper);
32 }; 49 };
33 50
34 } // namespace chrome_browser_net 51 } // namespace chrome_browser_net
35 52
36 #endif // CHROME_BROWSER_NET_PREDICTOR_TAB_HELPER_H_ 53 #endif // CHROME_BROWSER_NET_PREDICTOR_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/net/predictor_browsertest.cc ('k') | chrome/browser/net/predictor_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698