third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h - Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h

Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #4 fix. Thanks @pkasting. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp ('K') | « third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h

diff --git a/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h b/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h

index bd36802ec110e53a8839116912b8bc28f06a2fe2..e67e6c74afb0fbea2f2d4f72b0bb44003e161e8d 100644

--- a/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h

+++ b/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h

@@ -16,7 +16,7 @@ public:

bool currentFrameIsComplete() override { return true; }

static PassRefPtr<StaticBitmapImage> create(PassRefPtr<SkImage>);

- virtual void destroyDecodedData(bool destroyAll) { }

+ virtual void destroyDecodedData() { }

virtual bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata);

virtual IntSize size() const;

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override;