third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp - Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

Issue 1857543002: Don't recreate SkImages for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #4 fix. Thanks @pkasting. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.h » ('j') | third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

index c9e585a53181716764b22aa3db8880a33067883f..f6ae0b33dda970ad1879c8005330cf2bffc61427 100644

--- a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

+++ b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

@@ -51,7 +51,7 @@ public:

bool maybeAnimated() override { return true; }

bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }

IntSize size() const override { return IntSize(); }

- void destroyDecodedData(bool) override { }

+ void destroyDecodedData() override { }

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override { }

PassRefPtr<SkImage> imageForCurrentFrame() override { return nullptr; }

};

@@ -70,7 +70,7 @@ public:

bool maybeAnimated() override { return true; }

bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }

IntSize size() const override { return IntSize(); }

- void destroyDecodedData(bool) override { }

+ void destroyDecodedData() override { }

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override { }

bool isBitmapImage() const override { return true; }

@@ -91,7 +91,7 @@ public:

bool maybeAnimated() override { return true; }

bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }

IntSize size() const override { return IntSize(1, 1); }

- void destroyDecodedData(bool) override { }

+ void destroyDecodedData() override { }

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override { }

bool isBitmapImage() const override { return true; }