Issue 18575003: Merge two lines into one for V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18575003: Merge two lines into one for V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch} (Closed)

Created:
7 years, 5 months ago by haitao.feng

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Merge two lines into one for V8_TARGET_ARCH_${arch} and V8_HOST_ARCH_${arch} R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15500

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	src/atomicops.h	View		1 chunk	+3 lines, -6 lines	0 comments	Download
	M	src/strtod.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

haitao.feng

Sorry I missed those lines in https://codereview.chromium.org/18037002/. I wrote a short script and verified that ...

7 years, 5 months ago (2013-07-04 13:02:16 UTC) #1

Jakob Kummerow

7 years, 5 months ago (2013-07-05 08:15:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15500 (presubmit successful).