Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments
Patch Set: No need to add Default group to variation config Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.h
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h
index aaac42e6bb0fb3f11f22f28d1b2f5e9dca6cba59..14aec6712ed0f678efdeaab2aaf07a4714363a5c 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h
@@ -120,7 +120,8 @@ class PageLoadTracker {
void WebContentsShown();
// Returns true if the timing was successfully updated.
- bool UpdateTiming(const PageLoadTiming& timing);
+ bool UpdateTiming(const PageLoadTiming& timing,
+ const PageLoadMetadata& metadata);
bool HasBackgrounded();
void set_renderer_tracked(bool renderer_tracked);
@@ -192,6 +193,7 @@ class PageLoadTracker {
bool started_in_foreground_;
PageLoadTiming timing_;
+ PageLoadMetadata metadata_;
// This is a subtle member. If a provisional load A gets aborted by
// provisional load B, which gets aborted by C that eventually commits, then
@@ -258,7 +260,9 @@ class MetricsWebContentsObserver
scoped_ptr<PageLoadTracker> NotifyAbortedProvisionalLoadsNewNavigation(
content::NavigationHandle* new_navigation);
- void OnTimingUpdated(content::RenderFrameHost*, const PageLoadTiming& timing);
+ void OnTimingUpdated(content::RenderFrameHost*,
+ const PageLoadTiming& timing,
+ const PageLoadMetadata& metadata);
// True if the web contents is currently in the foreground.
bool in_foreground_;

Powered by Google App Engine
This is Rietveld 408576698