chrome/chrome_browser.gypi - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: No need to add Default group to variation config Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('K') | « chrome/browser/page_load_metrics/page_load_metrics_initialize.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index ec73df5b8bcdcc3481b71cbd0956666f3c8fa925..164e30766eea2cb2ce4771439cf0e68bd876ff8e 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -409,6 +409,8 @@

'browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/core_page_load_metrics_observer.cc',

'browser/page_load_metrics/observers/core_page_load_metrics_observer.h',

+ 'browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc',

+ 'browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc',

'browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h',

'browser/page_load_metrics/observers/google_captcha_observer.cc',