Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: components/page_load_metrics/renderer/page_timing_metrics_sender.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments
Patch Set: remove todo and fix up a test script Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/renderer/page_timing_metrics_sender.h
diff --git a/components/page_load_metrics/renderer/page_timing_metrics_sender.h b/components/page_load_metrics/renderer/page_timing_metrics_sender.h
index 0f5e1c9de7146ef1c27b49710a3e8944a6db04b2..d5ef91faa28fdbe14adf14ab02e29718a1206c0b 100644
--- a/components/page_load_metrics/renderer/page_timing_metrics_sender.h
+++ b/components/page_load_metrics/renderer/page_timing_metrics_sender.h
@@ -8,6 +8,7 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "components/page_load_metrics/common/page_load_timing.h"
+#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
namespace base {
class Timer;
@@ -29,12 +30,14 @@ class PageTimingMetricsSender {
scoped_ptr<base::Timer> timer);
~PageTimingMetricsSender();
+ void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior);
void Send(const PageLoadTiming& timing);
protected:
base::Timer* timer() const { return timer_.get(); }
private:
+ void EnsureSendTimer();
void SendNow();
IPC::Sender* const ipc_sender_;
@@ -42,6 +45,10 @@ class PageTimingMetricsSender {
scoped_ptr<base::Timer> timer_;
PageLoadTiming last_timing_;
+ // The the sender keep track of metadata as it comes in, because the sender is
+ // scoped to a single committed load.
+ PageLoadMetadata metadata_;
+
DISALLOW_COPY_AND_ASSIGN(PageTimingMetricsSender);
};

Powered by Google App Engine
This is Rietveld 408576698