chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: remove todo and fix up a test script Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h ('k') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 88aeb9479d1af9e743097ac5c0a0e5df90e49148..5de79a21637d37da6ce4dbdf6655c3f7350514c4 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -99,9 +99,15 @@ void PageLoadMetricsObserverTestHarness::StartNavigation(const GURL& gurl) {

void PageLoadMetricsObserverTestHarness::SimulateTimingUpdate(

const PageLoadTiming& timing) {

- observer_->OnMessageReceived(

- PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),

- web_contents()->GetMainFrame());

+ SimulateTimingAndMetadataUpdate(timing, PageLoadMetadata());

+void PageLoadMetricsObserverTestHarness::SimulateTimingAndMetadataUpdate(

+ const PageLoadTiming& timing,

+ const PageLoadMetadata& metadata) {

+ observer_->OnMessageReceived(PageLoadMetricsMsg_TimingUpdated(

+ observer_->routing_id(), timing, metadata),

+ web_contents()->GetMainFrame());

}

const base::HistogramTester&