Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments
Patch Set: remove todo and fix up a test script Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 148ee64622f2ba6eed00bd1b56a6fa76f5cb1ffd..af2778d12a61b973106536d6dd966caeb0c10d1f 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -63,6 +63,8 @@ const char kHistogramParseBlockedOnScriptLoad[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoad";
const char kHistogramParseBlockedOnScriptLoadParseComplete[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoad.ParseComplete";
+const char kHistogramParseStartToFirstContentfulPaint[] =
+ "PageLoad.Timing2.ParseStartToFirstContentfulPaint";
const char kHistogramParseBlockedOnScriptLoadDocumentWrite[] =
"PageLoad.Timing2.ParseBlockedOnScriptLoadFromDocumentWrite";
const char kHistogramParseBlockedOnScriptLoadDocumentWriteParseComplete[] =
@@ -290,6 +292,11 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
}
}
if (!timing.parse_start.is_zero()) {
+ if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
+ info)) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramParseStartToFirstContentfulPaint,
+ timing.first_contentful_paint - timing.parse_start);
+ }
const bool incomplete_parse_in_foreground =
timing.parse_stop.is_zero() && info.started_in_foreground &&
info.first_background_time.is_zero();
« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698