Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments
Patch Set: No need to add Default group to variation config Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 10 #include "components/page_load_metrics/common/page_load_timing.h"
11 #include "content/public/renderer/render_frame_observer.h" 11 #include "content/public/renderer/render_frame_observer.h"
12 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
12 13
13 namespace base { 14 namespace base {
14 class Timer; 15 class Timer;
15 } // namespace base 16 } // namespace base
16 17
17 namespace page_load_metrics { 18 namespace page_load_metrics {
18 19
19 class PageTimingMetricsSender; 20 class PageTimingMetricsSender;
20 21
21 // MetricsRenderFrameObserver observes RenderFrame notifications, and 22 // MetricsRenderFrameObserver observes RenderFrame notifications, and
22 // sends page load timing information to the browser process over IPC. 23 // sends page load timing information to the browser process over IPC.
23 class MetricsRenderFrameObserver : public content::RenderFrameObserver { 24 class MetricsRenderFrameObserver : public content::RenderFrameObserver {
24 public: 25 public:
25 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); 26 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
26 ~MetricsRenderFrameObserver() override; 27 ~MetricsRenderFrameObserver() override;
27 28
28 // RenderFrameObserver implementation 29 // RenderFrameObserver implementation
29 void DidChangePerformanceTiming() override; 30 void DidChangePerformanceTiming() override;
31 void DidObserveLoadingBehavior(
32 blink::WebLoadingBehaviorFlag behavior) override;
30 void DidCommitProvisionalLoad(bool is_new_navigation, 33 void DidCommitProvisionalLoad(bool is_new_navigation,
31 bool is_same_page_navigation) override; 34 bool is_same_page_navigation) override;
32 35
33 private: 36 private:
34 // Will be null when we're not actively sending metrics. 37 // Will be null when we're not actively sending metrics.
35 scoped_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; 38 scoped_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
36 39
37 void SendMetrics(); 40 void SendMetrics();
38 virtual bool ShouldSendMetrics() const; 41 virtual bool ShouldSendMetrics() const;
39 virtual PageLoadTiming GetTiming() const; 42 virtual PageLoadTiming GetTiming() const;
40 virtual scoped_ptr<base::Timer> CreateTimer() const; 43 virtual scoped_ptr<base::Timer> CreateTimer() const;
41 virtual bool HasNoRenderFrame() const; 44 virtual bool HasNoRenderFrame() const;
42 45
43 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 46 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
44 }; 47 };
45 48
46 } // namespace page_load_metrics 49 } // namespace page_load_metrics
47 50
48 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_ OBSERVER_H_ 51 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_ OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698