Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: components/page_load_metrics/common/page_load_timing.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments
Patch Set: clean up unit tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_
7 7
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 9
10 namespace page_load_metrics { 10 namespace page_load_metrics {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 base::TimeDelta first_text_paint; 49 base::TimeDelta first_text_paint;
50 // Time when the first image is painted. 50 // Time when the first image is painted.
51 base::TimeDelta first_image_paint; 51 base::TimeDelta first_image_paint;
52 // Time when the first contentful thing (image, text, etc.) is painted. 52 // Time when the first contentful thing (image, text, etc.) is painted.
53 base::TimeDelta first_contentful_paint; 53 base::TimeDelta first_contentful_paint;
54 54
55 // If you add additional members, also be sure to update operator==, 55 // If you add additional members, also be sure to update operator==,
56 // page_load_metrics_messages.h, and IsEmpty(). 56 // page_load_metrics_messages.h, and IsEmpty().
57 }; 57 };
58 58
59 struct PageLoadMetadata {
60 PageLoadMetadata();
61 bool operator==(const PageLoadMetadata& other) const;
62 // These are packed blink::WebExperimentData enums.
63 int experiment_flags;
Bryan McQuade 2016/04/07 14:25:14 nit: for structs with no constructor logic, i pref
Charlie Harrison 2016/04/07 16:38:57 Done.
64 };
65
59 } // namespace page_load_metrics 66 } // namespace page_load_metrics
60 67
61 #endif // COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_ 68 #endif // COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698