Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments
Patch Set: clean up unit tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
8 #include "chrome/test/base/in_process_browser_test.h" 9 #include "chrome/test/base/in_process_browser_test.h"
9 #include "chrome/test/base/ui_test_utils.h" 10 #include "chrome/test/base/ui_test_utils.h"
10 #include "net/test/embedded_test_server/embedded_test_server.h" 11 #include "net/test/embedded_test_server/embedded_test_server.h"
11 12
12 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 13 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
13 public: 14 public:
14 MetricsWebContentsObserverBrowserTest() {} 15 MetricsWebContentsObserverBrowserTest() {}
15 ~MetricsWebContentsObserverBrowserTest() override {} 16 ~MetricsWebContentsObserverBrowserTest() override {}
16 17
17 protected: 18 protected:
(...skipping 30 matching lines...) Expand all
48 embedded_test_server()->GetURL("/title1.html")); 49 embedded_test_server()->GetURL("/title1.html"));
49 ui_test_utils::NavigateToURL( 50 ui_test_utils::NavigateToURL(
50 browser(), embedded_test_server()->GetURL("/title1.html#hash")); 51 browser(), embedded_test_server()->GetURL("/title1.html#hash"));
51 ui_test_utils::NavigateToURL(browser(), 52 ui_test_utils::NavigateToURL(browser(),
52 embedded_test_server()->GetURL("/title2.html")); 53 embedded_test_server()->GetURL("/title2.html"));
53 54
54 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 55 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
55 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 56 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
56 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 57 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
57 } 58 }
59
60 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
61 PreloadDocumentWrite) {
62 ASSERT_TRUE(embedded_test_server()->Start());
63
64 ui_test_utils::NavigateToURL(
65 browser(), embedded_test_server()->GetURL(
66 "/page_load_metrics/document_write_external_script.html"));
67 ui_test_utils::NavigateToURL(browser(),
68 embedded_test_server()->GetURL("/title2.html"));
69
70 histogram_tester_.ExpectTotalCount(
71 internal::kHistogramDocWriteDomLoadingToFirstContentfulPaint, 1);
72 }
73
74 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
75 NoPreloadDocumentWrite) {
76 ASSERT_TRUE(embedded_test_server()->Start());
77
78 ui_test_utils::NavigateToURL(browser(),
79 embedded_test_server()->GetURL("/title1.html"));
80 ui_test_utils::NavigateToURL(browser(),
81 embedded_test_server()->GetURL("/title2.html"));
82 histogram_tester_.ExpectTotalCount(
83 internal::kHistogramDocWriteDomLoadingToFirstContentfulPaint, 0);
84 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698