SkiaExamples improvements.

SkiaExamples improvements.

Make it possible for a client to write a Hello World in less than 50 lines.

R=caryclark@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10319

[sglez, 2013-07-02 21:35:27]

Hey Mike.
Since Cary is on vacation, could you review this code?

It's a modification to the HelloWorld framework to make it more user friendly.
(From 0 to canvas in 30 lines. See the tutorial:
https://sites.google.com/site/skiadocs/developer-documentation/creating-a-ski...)

Unfortunately renaming the files makes the diff useless..

[sglez, 2013-07-03 15:53:25]

Cary,
I sent this out to Mike yesterday to ask for a review since you are on vacation,
but didn't actually include Mike as a reviewer...

Could you review this after you get back?

Thanks!

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
File experimental/SkiaExamples/SkExample.cpp (right):

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.cpp:140: bool SkExample::userExampleExists =
false;
Lines 136  to 140 have changes from BaseExample.cpp. Everything above is
untouched

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.cpp:144: 
Removed HelloWorldSkia.cpp and inserted its contents here to be used if the
programmer doesn't provide one.

[caryclark, 2013-07-08 12:42:35]

I need to play with this patch to understand it better -- for instance, what
replaces the deleted .gyp?

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
File experimental/SkiaExamples/SkExample.cpp (right):

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.cpp:245: SkOSWindow* userExample =
SkExample::create_user_example(hwnd, argc, argv);
(*SkExample::create_user_example)(hwnd, ...

(and rename create_user_example as suggested in the .h)

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
File experimental/SkiaExamples/SkExample.h (right):

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.h:20: class HelloSkia;
remove this if it isn't required for this header

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.h:34: static SkOSWindow*
(*create_user_example) (void* hwnd, int argc, char** argv);
use gCreateUserExample to hint to reader that this is a global variable
(gUserExampleFuncPtr might be better)
create_user_example looks like its a local (non-exported) function

also, public variables are usually at the bottom of the class, just above the
private: section

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.h:38: public:
unindent

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.h:41: }
add a blank line here

https://codereview.chromium.org/18574002/diff/2001/experimental/SkiaExamples/...
experimental/SkiaExamples/SkExample.h:78: static bool userExampleExists;
use 'gUserExampleExists' to hint to reader that this is a global

[sglez, 2013-07-23 20:50:23]

Requesting review.

[caryclark, 2013-07-23 20:55:39]

lgtm

[sglez, 2013-07-24 17:48:08]

Committed patchset #3 manually as r10319 (presubmit successful).