chrome/browser/renderer_host/predictor_resource_throttle.h - Issue 1857383002: Refactor net predictor to use ResourceThrottles

Side by Side Diff: chrome/browser/renderer_host/predictor_resource_throttle.h

Issue 1857383002: Refactor net predictor to use ResourceThrottles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/profiles/profile_io_data.h ('K') | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/renderer_host/predictor_resource_throttle.cc » ('j') | chrome/browser/renderer_host/predictor_resource_throttle.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_RENDERER_HOST_PREDICTOR_RESOURCE_THROTTLE_H_

	6 #define CHROME_BROWSER_RENDERER_HOST_PREDICTOR_RESOURCE_THROTTLE_H_

	7

	8 #include "content/public/browser/resource_throttle.h"

	9 #include "chrome/browser/net/predictor.h"

	10 #include "net/url_request/url_request.h"
	mmenke 2016/04/07 22:12:50 Think these two can be forward declared. Same with Think these two can be forward declared. Same with RedirectInfo. Charlie Harrison 2016/05/23 14:16:20 Done. Show quoted text On 2016/04/07 22:12:50, mmenke wrote: > Think these two can be forward declared. Same with RedirectInfo. Done.
	11

	12 class PredictorResourceThrottle : public content::ResourceThrottle {
	mmenke 2016/04/07 22:12:50 Hrm...The predictor itself is in net/, wonder if t Hrm...The predictor itself is in net/, wonder if this should be as well. That does introduce a dependency on loader/ in net, but the predictor itself does depend on a fair number of things it probably shouldn't. Perhaps its' the predictor which doesn't belong in there. mmenke 2016/04/07 22:12:50 This should have some docs. This should have some docs. Charlie Harrison 2016/04/07 22:20:41 I agree that the predictor seems like it does not Show quoted text On 2016/04/07 at 22:12:50, mmenke wrote: > Hrm...The predictor itself is in net/, wonder if this should be as well. That does introduce a dependency on loader/ in net, but the predictor itself does depend on a fair number of things it probably shouldn't. Perhaps its' the predictor which doesn't belong in there. I agree that the predictor seems like it does not truly belong in net. I can look into moving it over here. Charlie Harrison 2016/05/23 14:16:20 I've added a TODO. Show quoted text On 2016/04/07 22:20:41, csharrison wrote: > On 2016/04/07 at 22:12:50, mmenke wrote: > > Hrm...The predictor itself is in net/, wonder if this should be as well. That > does introduce a dependency on loader/ in net, but the predictor itself does > depend on a fair number of things it probably shouldn't. Perhaps its' the > predictor which doesn't belong in there. > > I agree that the predictor seems like it does not truly belong in net. I can > look into moving it over here. I've added a TODO. Charlie Harrison 2016/05/23 14:16:20 Done. Show quoted text On 2016/04/07 22:12:50, mmenke wrote: > This should have some docs. Done.
	13 public:

	14 PredictorResourceThrottle(net::URLRequest* request,

	15 chrome_browser_net::Predictor* predictor);

	16 ~PredictorResourceThrottle() override;

	17

	18 // content::ResourceThrottle:

	19 void WillStartRequest(bool* defer) override;

	20 void WillRedirectRequest(const net::RedirectInfo& redirect_info,

	21 bool* defer) override;

	22 const char* GetNameForLogging() const override;

	23

	24 private:

	25 net::URLRequest* request_;

	26 chrome_browser_net::Predictor* predictor_;
	mmenke 2016/04/07 22:12:50 DISALLOW_COPY_AND_ASSIGN, and include base/macros. DISALLOW_COPY_AND_ASSIGN, and include base/macros.h. Charlie Harrison 2016/05/23 14:16:20 Done. Show quoted text On 2016/04/07 22:12:50, mmenke wrote: > DISALLOW_COPY_AND_ASSIGN, and include base/macros.h. Done.
	27 };

	28

	29 #endif // CHROME_BROWSER_RENDERER_HOST_PREDICTOR_RESOURCE_THROTTLE_H_

OLD	NEW